atom feed3 messages in org.freebsd.freebsd-stableRe: RFC: side effects of fixing loade...
FromSent OnAttachments
Luigi RizzoJan 18, 2009 2:24 pm 
Andrew ThompsonJan 21, 2009 12:39 pm 
Scott UllrichMay 28, 2009 11:48 am 
Subject:Re: RFC: side effects of fixing loader_conf_files handling
From:Andrew Thompson (thom@FreeBSD.org)
Date:Jan 21, 2009 12:39:31 pm
List:org.freebsd.freebsd-stable

On Sun, Jan 18, 2009 at 11:29:58PM +0100, Luigi Rizzo wrote:

hi,

Previously, the check for new assignments was incorrect, and it happened to ignored assignments which did not result in a buffer reallocation by the Forth interpreter (essentially, any string not longer than the current one was ignored).

An annoying side effect of the fix is that now people who (mistakenly) copied /boot/defaults/loader.conf into /boot/loader.conf (and possibly edit it), now create a loop because their /boot/loader.conf now contains

loader_conf_files="/boot/device.hints /boot/loader.conf
/boot/loader.conf.local"

which is not just a pure assignments.

I think we should remove the use of loader_conf_files=... from /boot/defaults/loader.conf, partly to prevent this kind of bugs, and partly because it is nice to have only "pure assigments" in this file.

If there are no objections, i will look at how to do it. Probably this requires putting the initial list of files somewhere else, probably in /boot/loader.rc after the

include /boot/loader.4th

statement.

Comments ?

That sounds good, thanks for working on this.

Andrew