atom feed4 messages in org.freebsd.freebsd-acpiprobable typo in acpi_cpu.c
FromSent OnAttachments
Andriy GaponFeb 11, 2008 1:22 pm 
Rui PauloFeb 11, 2008 4:24 pm 
Nate LawsonFeb 12, 2008 9:23 am 
John BaldwinFeb 12, 2008 11:08 am 
Subject:probable typo in acpi_cpu.c
From:Rui Paulo (rpa@FreeBSD.org)
Date:Feb 11, 2008 4:24:07 pm
List:org.freebsd.freebsd-acpi

On Feb 11, 2008, at 9:22 PM, Andriy Gapon wrote:

There is probably a typo in acpi_cpu.c, function acpi_cpu_startup: if (cpu_quirks && CPU_QUIRK_NO_C3) { <----- here sc->cpu_cx_count = sc->cpu_non_c3 + 1; }

Not sure how that affects the logic though.

You are right. This means that the C3 state will still be available on systems like those based on PIIX4.

Nate, could you please commit a fix for it?

Regards.

-- Rui Paulo