| Subject: | Re: Patch to add nic-se to whois | |
|---|---|---|
| From: | Will Andrews (wi...@physics.purdue.edu) | |
| Date: | May 21, 2001 12:30:44 am | |
| List: | org.freebsd.freebsd-audit | |
Refine Search
| From | Sent On | Attachments |
|---|---|---|
| Joachim Strömbergson | May 20, 2001 3:15 pm | .diff |
| Will Andrews | May 20, 2001 7:14 pm | |
| Joachim Strömbergson | May 21, 2001 12:24 am | |
| Peter Pentchev | May 21, 2001 12:29 am | |
| Will Andrews | May 21, 2001 12:30 am | |
| Will Andrews | May 21, 2001 12:38 am | |
| Peter Pentchev | May 21, 2001 12:39 am | |
| Dima Dorfman | May 21, 2001 12:49 am | |
| Peter Pentchev | May 21, 2001 12:54 am | |
| Jeroen C. van Gelderen | May 21, 2001 3:31 am | |
| Peter Pentchev | May 21, 2001 4:40 am | |
| Joachim Strömbergson | May 21, 2001 4:56 am |
| Subject: | Re: Patch to add nic-se to whois | |
|---|---|---|
| From: | Will Andrews (wi...@physics.purdue.edu) | |
| Date: | May 21, 2001 12:30:44 am | |
| List: | org.freebsd.freebsd-audit | |
On Mon, May 21, 2001 at 10:29:22AM +0300, Peter Pentchev wrote:
Attached is a slightly modified version of your patch, which preserves whitespace (tabs), and follows style(9) guidelines in ordering function arguments (as pointed out by Will :)
Actually, no... I was saying he introduced a functional bug (but as you pointed out, also a style(9) bug). Look at your own patch:
[...]
- while ((ch = getopt(argc, argv, "adgh:impQrR6")) != -1) { + while ((ch = getopt(argc, argv, "adghi:mpQrRs6")) != -1) { [...] - "usage: whois [-adgimpQrR6] [-h hostname] name ...\n"); + "usage: whois [-adgimpQrRs6] [-h hostname] name ...\n");
For goodness sakes, people, test your patches! ;-)
-- wca
To Unsubscribe: send mail to majo...@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message

