RE: [Xen-ia64-devel] [Q] About xc.domain_destroy_hook - Zhang, Xing Z - com.xensource.lists.xen-ia64-devel

3 messages in com.xensource.lists.xen-ia64-develRE: [Xen-ia64-devel] [Q] About xc.dom...

From	Sent On	Attachments
Masaki Kanno	30 Jan 2008 17:18
Zhang, Xing Z	30 Jan 2008 21:51
Masaki Kanno	30 Jan 2008 23:24

Subject:	RE: [Xen-ia64-devel] [Q] About xc.domain_destroy_hook
From:	Zhang, Xing Z (xing...@intel.com)
Date:	01/30/2008 09:51:58 PM
List:	com.xensource.lists.xen-ia64-devel

Hi Kan: When I implemented NVRAM, I found there were many difference shutdown ways for
HVM domain. So I added hook on each flow. Maybe Xend code merged some shutdown paths. You can try to remove it to see if
NVRAM still works. If fine, I think it is removable. Thx.

Good good study,day day up ! ^_^ -Wing(zhang xin)

OTC,Intel Corporation

-----Original Message----- From: xen-...@lists.xensource.com [mailto:xen-...@lists.xensource.com] On Behalf Of Masaki Kanno Sent: 2008?1?31? 9:19 To: xen-...@lists.xensource.com Subject: [Xen-ia64-devel] [Q] About xc.domain_destroy_hook

Hi,

I have a question.

XendDomainInfo.py: def shutdown(self, reason): """Shutdown a domain by signalling this via xenstored.""" log.debug('XendDomainInfo.shutdown(%s)', reason) <<snip>> # HVM domain shuts itself down only if it has PV drivers if self.info.is_hvm(): hvm_pvdrv = xc.hvm_get_param(self.domid, HVM_PARAM_CALLBACK_IRQ) if not hvm_pvdrv: code = REVERSE_DOMAIN_SHUTDOWN_REASONS[reason] here! --> xc.domain_destroy_hook(self.domid) log.info("HVM save:remote shutdown dom %d!", self.domid) xc.domain_shutdown(self.domid, code)

[Q] The line does not need, does it?

When I tested xm shutdown command for an HVM domain, I saw the following error message in xend-debug.log.

Nvram save successful! ERROR Internal error: Save to nvram fail! (9 = Bad file descriptor)

Also same message was seen in xm reboot command.

Nvram save successful! ERROR Internal error: Save to nvram fail! (9 = Bad file descriptor)

I think that xc.domain_destroy_hook() is called twice.

Best regards, Kan