atom feed6 messages in org.apache.wicket.devRe: Deprecate Component#onMarkupAttac...
FromSent OnAttachments
Martin GrigorovJan 31, 2012 8:44 am 
Igor VaynbergJan 31, 2012 9:17 am 
Martijn DashorstJan 31, 2012 9:37 am 
Christoph LeiterJan 31, 2012 9:50 am 
Martijn DashorstJan 31, 2012 12:25 pm 
Sven MeierJan 31, 2012 2:47 pm 
Subject:Re: Deprecate Component#onMarkupAttached() ?
From:Sven Meier (sv@meiers.net)
Date:Jan 31, 2012 2:47:46 pm
List:org.apache.wicket.dev

+1 same here

Sven

On 01/31/2012 06:18 PM, Igor Vaynberg wrote:

+1 to deprecate in 1.5.x and remove in 6.0

-igor

On Tue, Jan 31, 2012 at 8:44 AM, Martin Grigorov<mgri@apache.org> wrote:

Hi,

To solve https://issues.apache.org/jira/browse/WICKET-4361 I moved the call to Component#internalOnMarkupAttached() from MarkupContainer#add() to Component#onInitialize(). This change both solves the problem with the early load of the page's markup and improved a bit the performance because now there is no iteration over the children of the added component to call their #internalOnMarkupAttached().

Now I think Component#onMarkupAttached() becomes obsolete. #onInitialize() serves the same purpose, Should we deprecate it in 1.5.x and remove it in 6.0 ?

The commit diff is: http://git-wip-us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=557e43527a43dde43aa4e68d34a2a99bfabef210

-- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com