atom feed2 messages in org.kernel.vger.kernel-janitorsRe: [PATCH] NFC: st21nfca: Remove dou...
FromSent OnAttachments
Emil GoodeJun 2, 2014 7:20 am 
Christophe RICARDJul 25, 2014 2:13 am 
Subject:Re: [PATCH] NFC: st21nfca: Remove double assignment of .owner in struct device_driver
From:Christophe RICARD (chri@gmail.com)
Date:Jul 25, 2014 2:13:14 am
List:org.kernel.vger.kernel-janitors

On Mon, 2 Jun 2014 16:21:00 +0200 Emil Goode <emil@gmail.com> wrote:

The .owner member of struct device_driver is assigned THIS_MODULE twice.

Introduced by:

commit c44cb2edd01ca31471d9385f0895891b006ab904 ("NFC: dts: st21nfca: Add device-tree (Open Firmware) support to st21nfca")

diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c index 3f954ed..95942ca 100644 --- a/drivers/nfc/st21nfca/i2c.c +++ b/drivers/nfc/st21nfca/i2c.c @@ -710,7 +710,6 @@ static struct i2c_driver st21nfca_hci_i2c_driver = { .driver = { .owner = THIS_MODULE, .name = ST21NFCA_HCI_I2C_DRIVER_NAME, - .owner = THIS_MODULE, .of_match_table = of_match_ptr(of_st21nfca_i2c_match), }, .probe = st21nfca_hci_i2c_probe,