atom feed13 messages in org.apache.incubator.cloudstack-devCoding Convention Reminder
FromSent OnAttachments
Alex HuangJul 2, 2013 3:10 pm 
Edison SuJul 2, 2013 5:07 pm 
Prachi DamleJul 2, 2013 5:17 pm 
Min ChenJul 2, 2013 5:20 pm 
Vijayendra BhamidipatiJul 2, 2013 5:28 pm 
Rajesh BattalaJul 2, 2013 8:05 pm 
Alex HuangJul 2, 2013 8:31 pm 
Wido den HollanderJul 2, 2013 11:35 pm 
Ian DuffyJul 3, 2013 1:48 am 
Chip ChildersJul 3, 2013 8:59 am 
Alex HuangJul 3, 2013 9:23 am 
Brian FederleJul 3, 2013 9:34 am 
Daan HooglandJul 3, 2013 10:22 am 
Subject:Coding Convention Reminder
From:Alex Huang (Alex@citrix.com)
Date:Jul 2, 2013 3:10:54 pm
List:org.apache.incubator.cloudstack-dev

I like to remind everyone to review our coding conventions. Our coding
conventions have been going all over the place recently. Please take a look.

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions

I also like to propose that we extend the 120 column limit to 180 columns.

I recently was reading the following code. If it followed even our current
coding conventions, this would have been 11 lines but it ends up to be 23 lines,
more than doubled. The whole file was like this. Just thinking about all the
extra scrolling I have to do makes my cts act up. We are in the 21st century
and using wide screen lcd monitors. Let's not format our code to fit 80 column
amber text screens please!

What's worse is I've found that some people are actively breaking existing
source code to 80 columns, causing a bunch of unnecessary merge activities. On
Eclipse, you can actually set all types of formatting rules. I can send out my
epf (eclipse preferences file) if you don't want to deal with the trouble. DiskOfferingVO diskOffering = _diskOfferingDao .findById(vol.getDiskOfferingId()); if (diskOffering.getUseLocalStorage()) { if (s_logger.isDebugEnabled()) { s_logger.debug("Local volume " + vol + " will be recreated on storage
pool " + assignedPool + " assigned by deploymentPlanner"); } VolumeTask task = new
VolumeTask(VolumeTaskType.RECREATE, vol, null); tasks.add(task); } else { if (s_logger.isDebugEnabled()) { s_logger.debug("Shared volume " + vol + " will be migrated on storage pool
" + assignedPool + " assigned by deploymentPlanner"); } VolumeTask task = new
VolumeTask(VolumeTaskType.MIGRATE, vol, assignedPool); tasks.add(task); }

Please be mindful of my cts. Thanks for caring about my health! :)

--Alex