-1 I'd suggest that Ryan re-work a couple things and submit another patch.

rcf2616: A client MUST include a Host header field in all HTTP/1.1 request messages . If the requested URI does not include an Internet host name for the service being requested, then the Host header field MUST be given with an empty value.

So you are saying that because an ipaddress is not an internet host name, the header field must be present but with an empty value. Seems like a reasonable intreptation. Can anyone confirm that?

While you are in the addHostRequestHeader, you might want to take care of that little unlabled todo comment. The host header should only be sent when using HTTP/1.1 and be completely left out for HTTP/1.0. You can search rfc1945 and rfc2616 for "Request Header Fields" to confirm. You can use the http11 boolean variable in a conditional.

For your isIpAddress method, it would have been nice if sun gave us a InetAddress.isIpAddress static method or somthing. But it doesn't see to be convinent to use the InetAddress class. Too bad.

- You may wnat to trim() your input string, else a leading/trailing blank will cause it to return false.

- I think a input value string of 259 sequential "." characters will return true.

- You might be better off using a StringTokenizer and split on the dot. you can then call countTokens() to see if it is in the ball park and then then use Integer.parseInt on the tokens. Return false immeadiately when you find a non-conformity. Still would prefer using some Java.net library method though, but I can't see anything there that would be useful.

- You may also wish to add a test case to TestMethodsNoHost for your isIpAddress method.

Ryan Lubke wrote: