atom feed7 messages in org.freebsd.freebsd-archRe: Where should I put ar71xx_* modules?
FromSent OnAttachments
Adrian ChaddJan 8, 2012 3:41 pm 
Stefan BethkeJan 8, 2012 11:58 pm 
Adrian ChaddJan 9, 2012 12:38 am 
Stefan BethkeJan 9, 2012 12:52 am 
Adrian ChaddJan 9, 2012 1:03 am 
John BaldwinJan 9, 2012 4:57 am 
Adrian ChaddJan 9, 2012 9:43 am 
Subject:Re: Where should I put ar71xx_* modules?
From:John Baldwin (jh@freebsd.org)
Date:Jan 9, 2012 4:57:06 am
List:org.freebsd.freebsd-arch

On Monday, January 09, 2012 4:04:14 am Adrian Chadd wrote:

On 9 January 2012 00:52, Stefan Bethke <st@lassitu.de> wrote:

We have lots of modules that have specific requirements; they're still

connected to the build. What warrants different handling here? You could put them under .if ${MACHINE_CPUARCH} != "mips" like a number of them are already.

Hm, I didn't want to add modules for a specific SoC that won't ever be built for any other platform. Eg, if someone does a XLR build, they shouldn't get ar71xx modules built.

Were you planning on including them in the ar71xx kernel configs via MODULES_OVERRIDE or some such? If so, that would be sufficient to get 'make tinderbox' to cover them at least (and hopefully tinderbox builds). In that case I think it is fine to not have them hooked up in the main sys/modules build. Or rather, if Warner commits his KERNOPTS thing, perhaps you could make sys/modules/Makefile include them on appropriate SoC kernels only.