| From | Sent On | Attachments |
|---|---|---|
| Alan Milligan | Dec 22, 2003 6:02 am | |
| Sam Varshavchik | Dec 22, 2003 4:12 pm | |
| Alan Milligan | Dec 23, 2003 6:14 am | |
| Sam Varshavchik | Dec 23, 2003 4:35 pm | |
| Alan Milligan | Dec 24, 2003 6:10 am |
| Subject: | [courier-users] To: postmaster@[x.x.x.x] patch | |
|---|---|---|
| From: | Alan Milligan (al...@balclutha.org) | |
| Date: | Dec 22, 2003 6:02:39 am | |
| List: | net.sourceforge.lists.courier-users | |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Some of you may recall that I presently have the misfortune of having my mail server listed on dsbl.org.
In order to deregister, a mail server is expected to be able to receive a To: header of the above format. dsbl actually suggests that this indeed is a valid rfc822 address.
I have included a patch to allow this address format within Courier, and would like to ask for it's inclusion (or something of it's ilk) into the distro at earliest convenience.
These patches were made against courier/module.esmtp of the 0.44.2.20031219 devel release and has been tested against internal and external deliveries.
I'm not entirely sure if this meets best-practice within the Courier code base - I'm calling rfc1035_aton, and this is causing a link requirement on lib1035.a in a couple of places. I'm not fully conversant with autoconf/automake, but I suspect courier/configure.in possibly needs this as well...
For this to work, you also need to place [x.x.x.x] in locals and in esmtpacceptmailfor. I believe this is not only convenient, but logically correct...
Cheers, Alan
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.3.3 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org Comment:
iD8DBQE/55DsCfroLk4EZpkRAqsmAJ4yy+m7vSqVuIe3MsCuHhL2LUFVPACfZFdd rZjEC07HAA37uN7airjxiQ4= =FLQK -----END PGP SIGNATURE-----
--- configure.in Mon Dec 22 17:31:50 2003 +++ configure.in.old Mon Dec 22 16:51:29 2003 @@ -202,7 +202,7 @@ [--with-courierdir Location of courier source code (main directory)], courierdir="$withval", courierdir="../..")
-CFLAGS="-I$srcdir/$courierdir -I$courierdir -I$srcdir/$courierdir/courier
-I$courierdir/courier -I$srcdir/$courierdir/rfc822 -I$srcdir/$courierdir/rfc1035
-I$srcdir/$courierdir/afx -I$srcdir/$courierdir/courier/libs
-I$srcdir/$courierdir/authlib $CFLAGS"
+CFLAGS="-I$srcdir/$courierdir -I$courierdir -I$srcdir/$courierdir/courier
-I$courierdir/courier -I$srcdir/$courierdir/rfc822 -I$srcdir/$courierdir/afx
-I$srcdir/$courierdir/courier/libs -I$srcdir/$courierdir/authlib $CFLAGS"
AC_SUBST(courierdir)
AC_ARG_WITH(mailuser, [--with-mailuser=user Specify mail user name
(defaults to mail)],
--- esmtp.c Mon Dec 22 16:48:28 2003 +++ esmtp.c.old Mon Dec 22 16:46:13 2003 @@ -9,7 +9,6 @@ #include "courier.h" #include "rw.h" #include "rfc822.h" -#include "rfc1035.h" #include "dbobj.h" #include "comfax.h" #include <string.h> @@ -65,25 +64,6 @@ seendot=1; seen1dot=1; } - else if (s->token == '[') - { - // doing dot-quad check ie bla@[x.x.x.x] ... - int buflen = strlen(s->next->ptr) -1; - if (s->next->ptr[buflen] == ']') { - char buf[buflen]; - memcpy(buf, s->next->ptr, buflen); - buf[buflen] = 0; -#if RFC1035_IPV6 - struct in6_addr in; -#else - struct in_addr in; -#endif - if (rfc1035_aton(buf, &in) == 0) - return (p); - } - break; - } - else break; }





