7 messages in org.apache.struts.devRE: committers attention - just a few...| From | Sent On | Attachments |
|---|---|---|
| Arron Bates | Feb 25, 2003 3:02 pm | |
| Karr, David | Feb 25, 2003 3:06 pm | |
| Craig R. McClanahan | Feb 25, 2003 3:25 pm | |
| David Graham | Feb 25, 2003 3:32 pm | |
| Arron Bates | Feb 25, 2003 3:41 pm | |
| David Morris | Feb 25, 2003 9:47 pm | |
| Ted Husted | Feb 26, 2003 5:25 am |
| Subject: | RE: committers attention - just a few moments... | |
|---|---|---|
| From: | Arron Bates (stru...@keyboardmonkey.com) | |
| Date: | Feb 25, 2003 3:41:57 pm | |
| List: | org.apache.struts.dev | |
Failing responses from people who are actually familiar with the nested tags and your changes, then I think you'll just have to use your own judgment. I had to make a similar decision recently wrt the Struts-EL tags. Test your changes as much as possible, and try to get some feedback from people who are using your tags. If you think it's safe to commit, then do it (but don't quote me on that :) ).
David
I think David articulates a rational approach. If you think the fix for nested tags should go in (in spite of being a larger patch than we might be normally comfortable with), and you've tested it as much as you can, I'm certainly not going to argue. Worst case - we do an RC2 with this fix to give the world one more shot at proving it's still got a problem.
Craig
This is the feedback I'm after.
Had I simply committed the patch that is on the big side, I would have been trounced. Especially seeing that time hasn't let me play apache recently, to then walk in and make such a large play (on RC1 day no less). Wouldn't have gone over well I imagine.
Arron.
BTW: So far, none of the early adopters have said their apps have broken with the new changes.