| From | Sent On | Attachments |
|---|---|---|
| Andrew Bogott | Jul 2, 2012 12:16 pm | |
| Russell Bryant | Jul 2, 2012 12:26 pm | |
| Joshua Harlow | Jul 2, 2012 2:41 pm | |
| Joshua Harlow | Jul 2, 2012 2:54 pm | |
| Gabriel Hurley | Jul 2, 2012 3:18 pm | |
| John Postlethwait | Jul 2, 2012 4:42 pm | |
| Christopher B Ferris | Jul 2, 2012 5:41 pm | |
| Thierry Carrez | Jul 3, 2012 2:31 am | |
| Thierry Carrez | Jul 3, 2012 2:34 am | |
| Doug Hellmann | Jul 3, 2012 5:37 am | |
| James E. Blair | Jul 3, 2012 6:55 am | |
| Joshua Harlow | Jul 3, 2012 10:46 am | |
| Dan Prince | Jul 3, 2012 10:59 am | |
| Gabriel Hurley | Jul 3, 2012 11:59 am | |
| Andrew Bogott | Jul 3, 2012 12:47 pm | |
| Joshua Harlow | Jul 3, 2012 2:09 pm | |
| James E. Blair | Jul 3, 2012 2:54 pm | |
| Eric Windisch | Jul 3, 2012 3:47 pm | |
| Andrew Bogott | Jul 3, 2012 3:54 pm | |
| Gabriel Hurley | Jul 3, 2012 4:53 pm | |
| Timothy Daly | Jul 3, 2012 5:27 pm | |
| Monty Taylor | Jul 3, 2012 6:17 pm | |
| Thierry Carrez | Jul 4, 2012 2:56 am | |
| Gabriel Hurley | Jul 4, 2012 3:17 pm | |
| Eric Windisch | Jul 4, 2012 4:11 pm | |
| Christopher B Ferris | Jul 5, 2012 4:29 am | |
| Sean Dague | Jul 5, 2012 6:55 am | |
| Doug Hellmann | Jul 5, 2012 7:16 am | |
| Joshua Harlow | Jul 5, 2012 10:21 am | |
| Mark McLoughlin | Jul 18, 2012 2:01 am | |
| Mark McLoughlin | Jul 18, 2012 2:13 am | |
| Mark McLoughlin | Jul 18, 2012 2:16 am | |
| Mark McLoughlin | Jul 18, 2012 2:23 am | |
| Thierry Carrez | Jul 18, 2012 4:00 pm | |
| Doug Hellmann | Jul 23, 2012 8:50 am | |
| Thierry Carrez | Jul 23, 2012 8:59 am | |
| Doug Hellmann | Jul 23, 2012 9:04 am | |
| Eric Windisch | Aug 2, 2012 1:05 pm | |
| Christopher B Ferris | Aug 2, 2012 2:08 pm | |
| Vishvananda Ishaya | Aug 2, 2012 3:47 pm | |
| Jay Pipes | Aug 2, 2012 5:18 pm | |
| Zhongyue Luo | Aug 2, 2012 5:24 pm | |
| Eric Windisch | Aug 2, 2012 5:51 pm | |
| Mark McLoughlin | Aug 2, 2012 10:26 pm | |
| Thierry Carrez | Aug 3, 2012 2:49 am | |
| Thierry Carrez | Aug 3, 2012 4:02 am | |
| Jay Pipes | Aug 3, 2012 9:25 am | |
| Eric Windisch | Aug 3, 2012 9:34 am |
| Subject: | Re: [Openstack] best practices for merging common into specific projects | |
|---|---|---|
| From: | Sean Dague (sda...@linux.vnet.ibm.com) | |
| Date: | Jul 5, 2012 6:55:21 am | |
| List: | net.launchpad.lists.openstack | |
On 07/03/2012 02:00 PM, Dan Prince wrote:
I don't see this as much different as any other patches to nova (or whatever project is using common). It should be a proper patch series. If the person pulling it in doesn't understand the merge well enough to produce the patch series with proper commit messages, then they are the wrong person to be doing the merge in the first place.
I went on a bit of a rant about this on IRC yesterday. While I agree a patch
series is appropriate for many new features and bug fixes I don't think it
should be required for keeping openstack-common in sync. Especially since we
don't merge tests from openstack-common which would help verify that the person
doing the merges doesn't mess up the order of the patchset. If we were to
include the tests from openstack-common in each project this could change my
mind.
If someone wants to split openstack-common changes into patchsets that might be
Okay in small numbers. If you are merging say 5-10 changes from openstack common
into all the various openstack projects that could translate into a rather large
number of reviews (25+) for things that have been already reviewed once. For me
using patchsets to keep openstack-common in sync just causes thrashing of
Jenkins, SmokeStack, etc. for things that have already been gated. Seems like an
awful waste of review/CI time. In my opinion patchsets are the way to go with
getting things into openstack-common... but not when syncing to projects.
Hopefully this situation is short lived however and we start using a proper
library sooner rather than later.
+1. I think the bisectability isn't a clear win without the unit tests coming over, and the rest is just more reviews (which are already in scarce supply), and more jenkins time which just slows down everything else.
-Sean
-- Sean Dague IBM Linux Technology Center email: sda...@linux.vnet.ibm.com alt-email: slda...@us.ibm.com
_______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : open...@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp





