atom feed48 messages in net.launchpad.lists.openstackRe: [Openstack] best practices for me...
FromSent OnAttachments
Andrew BogottJul 2, 2012 12:16 pm 
Russell BryantJul 2, 2012 12:26 pm 
Joshua HarlowJul 2, 2012 2:41 pm 
Joshua HarlowJul 2, 2012 2:54 pm 
Gabriel HurleyJul 2, 2012 3:18 pm 
John PostlethwaitJul 2, 2012 4:42 pm 
Christopher B FerrisJul 2, 2012 5:41 pm 
Thierry CarrezJul 3, 2012 2:31 am 
Thierry CarrezJul 3, 2012 2:34 am 
Doug HellmannJul 3, 2012 5:37 am 
James E. BlairJul 3, 2012 6:55 am 
Joshua HarlowJul 3, 2012 10:46 am 
Dan PrinceJul 3, 2012 10:59 am 
Gabriel HurleyJul 3, 2012 11:59 am 
Andrew BogottJul 3, 2012 12:47 pm 
Joshua HarlowJul 3, 2012 2:09 pm 
James E. BlairJul 3, 2012 2:54 pm 
Eric WindischJul 3, 2012 3:47 pm 
Andrew BogottJul 3, 2012 3:54 pm 
Gabriel HurleyJul 3, 2012 4:53 pm 
Timothy DalyJul 3, 2012 5:27 pm 
Monty TaylorJul 3, 2012 6:17 pm 
Thierry CarrezJul 4, 2012 2:56 am 
Gabriel HurleyJul 4, 2012 3:17 pm 
Eric WindischJul 4, 2012 4:11 pm 
Christopher B FerrisJul 5, 2012 4:29 am 
Sean DagueJul 5, 2012 6:55 am 
Doug HellmannJul 5, 2012 7:16 am 
Joshua HarlowJul 5, 2012 10:21 am 
Mark McLoughlinJul 18, 2012 2:01 am 
Mark McLoughlinJul 18, 2012 2:13 am 
Mark McLoughlinJul 18, 2012 2:16 am 
Mark McLoughlinJul 18, 2012 2:23 am 
Thierry CarrezJul 18, 2012 4:00 pm 
Doug HellmannJul 23, 2012 8:50 am 
Thierry CarrezJul 23, 2012 8:59 am 
Doug HellmannJul 23, 2012 9:04 am 
Eric WindischAug 2, 2012 1:05 pm 
Christopher B FerrisAug 2, 2012 2:08 pm 
Vishvananda IshayaAug 2, 2012 3:47 pm 
Jay PipesAug 2, 2012 5:18 pm 
Zhongyue LuoAug 2, 2012 5:24 pm 
Eric WindischAug 2, 2012 5:51 pm 
Mark McLoughlinAug 2, 2012 10:26 pm 
Thierry CarrezAug 3, 2012 2:49 am 
Thierry CarrezAug 3, 2012 4:02 am 
Jay PipesAug 3, 2012 9:25 am 
Eric WindischAug 3, 2012 9:34 am 
Subject:Re: [Openstack] best practices for merging common into specific projects
From:Sean Dague (sda@linux.vnet.ibm.com)
Date:Jul 5, 2012 6:55:21 am
List:net.launchpad.lists.openstack

On 07/03/2012 02:00 PM, Dan Prince wrote:

I don't see this as much different as any other patches to nova (or whatever project is using common). It should be a proper patch series. If the person pulling it in doesn't understand the merge well enough to produce the patch series with proper commit messages, then they are the wrong person to be doing the merge in the first place.

I went on a bit of a rant about this on IRC yesterday. While I agree a patch
series is appropriate for many new features and bug fixes I don't think it
should be required for keeping openstack-common in sync. Especially since we
don't merge tests from openstack-common which would help verify that the person
doing the merges doesn't mess up the order of the patchset. If we were to
include the tests from openstack-common in each project this could change my
mind.

If someone wants to split openstack-common changes into patchsets that might be
Okay in small numbers. If you are merging say 5-10 changes from openstack common
into all the various openstack projects that could translate into a rather large
number of reviews (25+) for things that have been already reviewed once. For me
using patchsets to keep openstack-common in sync just causes thrashing of
Jenkins, SmokeStack, etc. for things that have already been gated. Seems like an
awful waste of review/CI time. In my opinion patchsets are the way to go with
getting things into openstack-common... but not when syncing to projects.

Hopefully this situation is short lived however and we start using a proper
library sooner rather than later.

+1. I think the bisectability isn't a clear win without the unit tests coming over, and the rest is just more reviews (which are already in scarce supply), and more jenkins time which just slows down everything else.

-Sean