2 messages in net.sourceforge.lists.courier-sqwebmail[sqwebmail] XHTML validation: folder_...
FromSent OnAttachments
Pawel TeczaJul 5, 2006 4:49 am 
Sam VarshavchikJul 5, 2006 2:02 pm 
Actions with this message:
Paste this link in email or IM:
Paste this link in email or IM:
Atom feed for this thread
Paste this URL into your reader:
Subject:[sqwebmail] XHTML validation: folder_err_msgActions...
From:Pawel Tecza (p.te@net.icm.edu.pl)
Date:Jul 5, 2006 4:49:22 am
List:net.sourceforge.lists.courier-sqwebmail

Hi Sam,

This is my first XHTML validation related patch. I have found that in function folder_list2() (folder.c file) which displays folder error message you don't close <p> tag.

I fixed it and moved HTML code from this function to folders.html template, because IMHO hardcoded HTML code is not a good idea. I have also unified HTML code for error messages in the template. The "size" and "color" attributes were removed, because there are unnecessary if you use "class" attribute.

Any comments? :)

Best regards,

Pawel

--- courier-0.53.2.20060702/webmail/folder.c-orig 2006-07-05 13:20:02.000000000
+0200 +++ courier-0.53.2.20060702/webmail/folder.c 2006-07-05 13:20:23.000000000 +0200 @@ -4343,7 +4343,7 @@ { if (folder_err_msg) { - printf("<p>%s<br /><br />\n", folder_err_msg); + printf("%s\n", folder_err_msg); } }

--- courier-0.53.2.20060702/webmail/html/en-us/folders.html-orig 2006-07-05
13:14:47.000000000 +0200 +++ courier-0.53.2.20060702/webmail/html/en-us/folders.html 2006-07-05
13:18:43.000000000 +0200 @@ -14,13 +14,13 @@ <!--

[#$UNREAD=(%u unread messages)#] -[#$INVALID=<font class="error" style="color: #ff0000" size="+1">Invalid folder
name</font>#] -[#$EXISTS=<font class="error" style="color: #ff0000" size="+1">Folder already
exists</font>#] -[#$DELETE=<font class="error" style="color: #ff0000" size="+1">Unable to delete
or rename this folder - folder contains messages or is used by a mail
filter</font>#] -[#$DELETEPERMS=<span class="error">You do not have the permission to delete
this folder</span>#] -[#$CREATEPERMS=<span class="error">You do not have the permission to create
this folder</span>#] -[#$RENAME=<span class="error">You do not have the permission to rename this
folder</span>#] -[#$WASSENT=<span style="color: #008000" class="sentmsg">Your message has been
sent.</span>#] +[#$INVALID=<p><span class="error">Invalid folder name</span></p><br />#] +[#$EXISTS=<p><span class="error">Folder already exists</span></p><br />#] +[#$DELETE=<p><span class="error">Unable to delete or rename this folder -
folder contains messages or is used by a mail filter</span></p><br />#] +[#$DELETEPERMS=<p><span class="error">You do not have the permission to delete
this folder</span></p><br />#] +[#$CREATEPERMS=<p><span class="error">You do not have the permission to create
this folder</span></p><br />#] +[#$RENAME=<p><span class="error">You do not have the permission to rename this
folder</span></p><br />#] +[#$WASSENT=<p><span class="sentmsg">Your message has been sent.</span></p><br
/>#] [#$INBOX=INBOX#] [#$DRAFTS=Drafts#] [#$SENT=Sent#]