No, he's right. sysinstall is definitely broken in this respect, and
I'm definitely interested in your patches to fix it. :)
The patches are attached...
In either the case that no make.conf exists, or one exists without a
USA_RESIDENT line in it, the line is added, regardless of if I have
confirmed that the default NO is correct or not.
Hmm, we probably shouldn't do this. I think your first patchset is
actually the proper one. Ultimately, the user needs to choose whether
or not they are in the U.S., we should never choose this for them. Thus,
we should only write anything out if we ask them the question.
In the case that make.conf has a USA_RESIDENT line, I only overwrite that
line if the user has answered the question 'are you really a us resident'.