| Subject: | Re: Exceptions used in oak-core | |
|---|---|---|
| From: | Thomas Mueller (muel...@adobe.com) | |
| Date: | Mar 22, 2012 5:49:06 am | |
| List: | org.apache.jackrabbit.oak-dev | |
Refine Search
| From | Sent On | Attachments |
|---|---|---|
| Angela Schreiber | Mar 22, 2012 2:48 am | |
| Michael Dürig | Mar 22, 2012 3:04 am | |
| Julian Reschke | Mar 22, 2012 3:53 am | |
| Michael Dürig | Mar 22, 2012 4:17 am | |
| Jukka Zitting | Mar 22, 2012 4:20 am | |
| Michael Dürig | Mar 22, 2012 4:35 am | |
| Thomas Mueller | Mar 22, 2012 5:49 am | |
| Thomas Mueller | Mar 22, 2012 5:56 am | |
| Thomas Mueller | Mar 22, 2012 6:03 am | |
| Julian Reschke | Mar 22, 2012 6:12 am | |
| Michael Dürig | Mar 22, 2012 6:25 am | |
| Angela Schreiber | Mar 27, 2012 6:07 am |
| Subject: | Re: Exceptions used in oak-core | |
|---|---|---|
| From: | Thomas Mueller (muel...@adobe.com) | |
| Date: | Mar 22, 2012 5:49:06 am | |
| List: | org.apache.jackrabbit.oak-dev | |
Hi,
Here's my take at this: I'd use exceptions as sparingly as possible and only for cases where something unexpected (an exception!) happens. That is, I wouldn't use exceptions e.g. for items not being found. This is clearly something that happens all the time and is by no means unexpected.
For the cases where exceptions are involved I would define our own very small set of exceptions and make them all *unchecked*. Checked exceptions compose very badly wrt. lazyness. For example an iterator which lazily fetches its items on next() has no clean way of handling exceptions in the next() method.
Only at the very last instance (i.e. in the jcr component) I would actually create and throw the various RepositoryExceptions.
I completely agree with this view.
Regards, Thomas

