3 messages in org.openssl.openssl-devRE: [openssl.org #1794] [PATCH] SRP i...
FromSent OnAttachments
Thomas Wu (thomwu) via RTNov 26, 2008 10:45 pm 
Stephen Henson via RTNov 27, 2008 4:42 am 
Thomas Wu (thomwu)Nov 27, 2008 1:40 pm 
Actions with this message:
Paste this link in email or IM:
Paste this link in email or IM:
Atom feed for this thread
Paste this URL into your reader:
Subject:RE: [openssl.org #1794] [PATCH] SRP in OpenSSL 0.9.9 Actions...
From:Thomas Wu (thomwu) (tho@cisco.com)
Date:Nov 27, 2008 1:40:04 pm
List:org.openssl.openssl-dev

A few initial comments.

The copyright notice in srp.c gives the impression Eric Young wrote

that file... I'm assuming he didn't and it > is a combination of work from other files in apps he did write.

I believe that is the case. I'll update the copyright notice in the next version of the patch.

The indentation in srp.c (perhaps as a result) is very inconsistent.

Indentation in other files doesn't follow the "standard" of the rest of OpenSSL (well most of it).

In a couple of files the low level SHA1 digest API is used directly. That should be avoided because it precludes use of ENGINEs in future. Use EVP instead.

Thanks for the comments - I will make the suggested fixes and send an updated patch early next week.

Tom

______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List open@openssl.org Automated List Manager majo@openssl.org