3 messages in net.sourceforge.lists.courier-sqwebmailRe: [sqwebmail] [PATCH] Forbid rename...
FromSent OnAttachments
Marcin SemeniukSep 5, 2006 3:47 am.patch
Sam VarshavchikSep 5, 2006 5:03 pm 
Marcin SemeniukSep 6, 2006 12:49 am 
Actions with this message:
Paste this link in email or IM:
Paste this link in email or IM:
Atom feed for this thread
Paste this URL into your reader:
Subject:Re: [sqwebmail] [PATCH] Forbid rename folder if new name contain dotActions...
From:Sam Varshavchik (mrs@courier-mta.com)
Date:Sep 5, 2006 5:03:43 pm
List:net.sourceforge.lists.courier-sqwebmail

Marcin Semeniuk writes:

Hello Sam,

I noticed that I can't create folder with dot in name, but I can change name to one with dot and webmail create tree of folders. I think it's inconsistency, so i made patch that forbid to rename folder if new name contain dot.

When you see my version of this patch you'll slap yourself on the head, for not seeing a much simpler fix.

As far as your other patch -- trimming off trailing colons in folder names on the mail filtering screen -- again, you need to kick things up a notch. For certain options, fieldname may be null, so you'll be freeing a NULL. Oops.

I'll do that myself, and you'll have to test my fix yourself. You need to be more careful in the future.