18 messages in com.xensource.lists.xen-develRe: [Xen-devel] [PATCH] fix broken ACM
FromSent OnAttachments
aq22 Jun 2005 10:39.patch
Keir Fraser22 Jun 2005 10:51 
aq22 Jun 2005 10:52 
aq22 Jun 2005 11:22 
Stefan Berger22 Jun 2005 20:41 
aq22 Jun 2005 20:55 
Stefan Berger22 Jun 2005 21:17 
Keir Fraser23 Jun 2005 00:48 
aq23 Jun 2005 00:56.patch
aq23 Jun 2005 01:04 
Keir Fraser23 Jun 2005 01:14 
aq23 Jun 2005 01:19 
Stefan Berger23 Jun 2005 07:56.patch
Keir Fraser23 Jun 2005 08:15 
aq23 Jun 2005 08:21 
Keir Fraser23 Jun 2005 08:51 
Stefan Berger23 Jun 2005 08:56 
aq23 Jun 2005 15:05 
Subject:Re: [Xen-devel] [PATCH] fix broken ACM
From:Keir Fraser (Keir@cl.cam.ac.uk)
Date:06/23/2005 08:51:54 AM
List:com.xensource.lists.xen-devel

On 23 Jun 2005, at 16:22, aq wrote:

Keir, certainly i understand your point. but this patch doesnt harm, anyway ;-)

We need to understand why a patch is useful before we apply it.

one annoying problem at the moment is that if we want to compile ACM in, we should modify the value of ACM_USE_SECURITY_POLICY, since the current default value is ACM_NULL_POLICY( which is meaningless as Keir pointed out )

any clean way to overcome this problem?

The way I skip building acm directory in the root Makefile is quite gross, and won't actually detect if you edit ACM_USE_SECURITY_POLICY. Probably need to think about ways of cleanly expressing a new build config option for security policies etc. Then Makefile decision can hook off of that.

-- Keir