atom feed5 messages in org.kernel.vger.kernel-janitorsRE: drivers/gpu/drm/radeon/radeon_gar...
FromSent OnAttachments
Fengguang WuOct 16, 2012 11:44 pm.diff
Christian KönigOct 17, 2012 2:26 am 
Deucher, AlexanderOct 17, 2012 9:41 am 
Fengguang WuOct 17, 2012 9:55 am 
Deucher, AlexanderOct 17, 2012 9:56 am 
Subject:RE: drivers/gpu/drm/radeon/radeon_gart.c:580:5: sparse: symbol 'radeon_vm_evict' was not declared. Should it be static?
From:Deucher, Alexander (Alex@amd.com)
Date:Oct 17, 2012 9:41:44 am
List:org.kernel.vger.kernel-janitors

Fengguang,

Do you want to send a formal patch, or should I just fix in my next radeon
-fixes pull request?

Alex

-----Original Message----- From: Christian König [mailto:deat@vodafone.de] Sent: Wednesday, October 17, 2012 5:26 AM To: Fengguang Wu Cc: kern@vger.kernel.org; Deucher, Alexander; Cherkasov, Dmitrii Subject: Re: drivers/gpu/drm/radeon/radeon_gart.c:580:5: sparse: symbol 'radeon_vm_evict' was not declared. Should it be static?

Hi Fengguang,

yes that's correct the function should be static.

Cheers, Christian.

On 17.10.2012 08:44, Fengguang Wu wrote:

Hi Christian,

FYI, there are new sparse warnings show up in

tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux master head: 8d2b6b3ae280dcf6f6c7a95623670a57cdf562ed commit: 90a51a329258e3c868f6f4c1fb264ca01c590c57 drm/radeon: allocate page tables on demand v4 date: 2 days ago

+ drivers/gpu/drm/radeon/radeon_gart.c:580:5: sparse: symbol 'radeon_vm_evict' was not declared. Should it be static?

vim +580 drivers/gpu/drm/radeon/radeon_gart.c

09db8644 Alex Deucher 2012-07-17 569 /** 90a51a32 Christian König 2012-10-09 570 * radeon_vm_evict - evict page table to make room for new one 90a51a32 Christian König 2012-10-09 571 * 90a51a32 Christian König 2012-10-09 572 * @rdev: radeon_device pointer 90a51a32 Christian König 2012-10-09 573 * @vm: VM we want to allocate something for 90a51a32 Christian König 2012-10-09 574 * 90a51a32 Christian König 2012-10-09 575 * Evict a VM from the lru, making sure that it isn't @vm. (cayman+). 90a51a32 Christian König 2012-10-09 576 * Returns 0 for success, - ENOMEM for failure. 90a51a32 Christian König 2012-10-09 577 * 90a51a32 Christian König 2012-10-09 578 * Global and local mutex must be locked! 90a51a32 Christian König 2012-10-09 579 */ 90a51a32 Christian König 2012-10-09 @580 int radeon_vm_evict(struct radeon_device *rdev, struct radeon_vm *vm) 90a51a32 Christian König 2012-10-09 581 { 90a51a32 Christian König 2012-10-09 582 struct radeon_vm *vm_evict; 90a51a32 Christian König 2012-10-09 583 90a51a32 Christian König 2012-10-09 584 if (list_empty(&rdev- vm_manager.lru_vm)) 90a51a32 Christian König 2012-10-09 585 return -ENOMEM; 90a51a32 Christian König 2012-10-09 586 90a51a32 Christian König 2012-10-09 587 vm_evict = list_first_entry(&rdev->vm_manager.lru_vm, 90a51a32 Christian König 2012-10-09 588 struct radeon_vm, list);

Shall we apply the attached diff?

Thanks, Fengguang