7 messages in com.mysql.lists.plusplusRE: A couple of patches
FromSent OnAttachments
Matt Dargavel29 Nov 2006 06:51 
Warren Young22 Dec 2006 06:04 
Matt Dargavel22 Dec 2006 08:21 
Matt Dargavel22 Dec 2006 08:34 
Warren Young22 Dec 2006 11:30 
Matt Dargavel02 Jan 2007 05:35 
Warren Young03 Jan 2007 05:01 
Subject:RE: A couple of patches
From:Matt Dargavel (ma@shout-telecoms.com)
Date:12/22/2006 08:34:49 AM
List:com.mysql.lists.plusplus

Hmm, I see- no patches on the delivered message for some reason. Here they are inline:

README.diff:

Index: C:/Documents and Settings/Matt Dargavel/My Documents/svn/mysqlpp/README =================================================================== --- C:/Documents and Settings/Matt Dargavel/My Documents/svn/mysqlpp/README (revision 1344) +++ C:/Documents and Settings/Matt Dargavel/My Documents/svn/mysqlpp/README (working copy) @@ -64,6 +64,9 @@ which has licensing ramifications. See README.mingw for details.

+ To get bakefile to create the makefiles necessary for each + platform, simply run bakefile_gen in the project root. +

Example Programs ~~~~~~~~~~~~~~~~

query.ccp.diff:

Index: C:/Documents and Settings/Matt Dargavel/My Documents/svn/mysqlpp/lib/query.cpp =================================================================== --- C:/Documents and Settings/Matt Dargavel/My Documents/svn/mysqlpp/lib/query.cpp (revision 1344) +++ C:/Documents and Settings/Matt Dargavel/My Documents/svn/mysqlpp/lib/query.cpp (working copy) @@ -31,11 +31,7 @@ namespace mysqlpp {

Query::Query(Connection* c, bool te) : -#if defined(_MSC_VER) -std::ostream(std::_Noinit), // prevents a double-init memory leak in RTL -#else -std::ostream(0), -#endif +std::ostream(&sbuffer_), OptionalExceptions(te), Lockable(false), def(this), @@ -42,7 +38,6 @@ conn_(c), success_(false) { - init(&sbuffer_); success_ = true; }

@@ -47,11 +42,7 @@ }

Query::Query(const Query& q) : -#if defined(_MSC_VER) -std::ostream(std::_Noinit), // prevents a double-init memory leak in RTL -#else -std::ostream(0), -#endif +std::ostream(&sbuffer_), OptionalExceptions(q.throw_exceptions()), Lockable(q.locked()), def(q.def), @@ -58,7 +49,6 @@ conn_(q.conn_), success_(q.success_) { - init(&sbuffer_); }

-----Original Message----- From: Matt Dargavel [mailto:ma@shout-telecoms.com] Sent: 22 December 2006 16:22 To: plus@lists.mysql.com Subject: RE: A couple of patches

No worries about the delay- took me long enough to get them done! :-) According to my sent items the patches were there, but here's the query patch and README patch again. Let me know if they don't arrive. These patches are based on today's svn, although I don't think they've changed from the last lot.

Merry Christmas!

Matt.

-----Original Message----- From: Warren Young [mailto:mysq@etr-usa.com] Sent: 22 December 2006 14:05 To: MySQL++ Mailing List Subject: Re: A couple of patches

Matt Dargavel wrote:

The const_string.h one undefines min and defines NOMINMAX. An alternative to this is to define NOMINMAX in the bakefile project creation, but this doesn't fix problems when people include const_string.h in their projects.

The README patch adds a little extra info.

The query.ccp patch presents the alternative solution for the memory leak, that we talked about some time ago.

Sorry for the delay in getting back to you on this. I just set it aside for consideration, and only later realized that the patches aren't actually attached.

Don't bother with the min/max one. I know what's going on there, and am taking that up separately.