Jonathan Wakely wrote:

Oh, crumb...This is the very error I foresaw when I decided the guard was necessary for the T* case, but in processing your previous message, I convinced myself it couldn't happen.

Actually, I conceived of it happening a little more verbosely:

Foo* bar = something_that_makes_foos(); ... many fascinating and interesting things happen here ... RefCountedPointer<Foo> qux(bar); ... still other stuff happens ... qux = bar; // who knows why, but say you do this...

Still unlikely, I admit...

I guess I'm satisfied leaving it unprotected until a need for protection is demonstrated.

It's always a third party that tells you how extensive the documentation needs to be. I'd only expect excellent documentation from you on these patches about six months from now when you are new to it again.

I discover lapses and even outright errors in the userman, for example, almost every time I reread a section of it. That's one reason I do it.