Re: [Xen-devel] [PATCH] Partial fix for compat build non-portability - Jan Beulich - com.xensource.lists.xen-devel

11 messages in com.xensource.lists.xen-develRe: [Xen-devel] [PATCH] Partial fix f...

From	Sent On	Attachments
john...@sun.com	10 Jan 2007 08:28
John Levon	10 Jan 2007 09:36
Jan Beulich	10 Jan 2007 09:42
John Levon	10 Jan 2007 09:50
Emmanuel Ackaouy	10 Jan 2007 09:58
Keir Fraser	10 Jan 2007 10:20
Keir Fraser	10 Jan 2007 10:27
John Levon	10 Jan 2007 10:30
John Levon	11 Jan 2007 08:29
Keir Fraser	17 Jan 2007 07:06
John Levon	17 Jan 2007 07:42

Subject:	Re: [Xen-devel] [PATCH] Partial fix for compat build non-portability
From:	Jan Beulich (jbeu...@novell.com)
Date:	01/10/2007 09:42:41 AM
List:	com.xensource.lists.xen-devel

--- a/xen/include/Makefile +++ b/xen/include/Makefile @@ -2,8 +2,28 @@ ifneq ($(CONFIG_COMPAT),)

compat-arch-$(CONFIG_X86) := x86_32

-headers-y := $(shell echo public/*.h | sed -e
's,[^[:space:]]*-[^[:space:]]*,,g' -e 's,public/,compat/,g') -headers-y := $(filter-out %/dom0_ops.h,$(headers-y)) +headers-y := \ + compat/acm.h \ + compat/acm_ops.h \ + compat/callback.h \ + compat/domctl.h \ + compat/elfnote.h \ + compat/event_channel.h \ + compat/features.h \ + compat/grant_table.h \ + compat/kexec.h \ + compat/memory.h \ + compat/nmi.h \ + compat/physdev.h \ + compat/platform.h \ + compat/sched.h \ + compat/sysctl.h \ + compat/trace.h \ + compat/vcpu.h \ + compat/version.h \ + compat/xen.h \ + compat/xencomm.h \ + compat/xenoprof.h headers-$(CONFIG_X86) += compat/arch-x86/xen.h headers-$(CONFIG_X86) += compat/arch-x86/xen-$(compat-arch-y).h headers-y += compat/arch-$(compat-arch-y).h compat/xlat.h

I certainly dislike this hunk - I intentionally didn't do it this way, as I
wanted to prevent having to touch this Makefile every time a header gets added/removed. If the current mechanism is too ugly (which I tend to agree) let's just do it by more explicit filtering, i.e. add xen-compat.h along with dom0_ops.h and remove all arch-*.h items via sed as is currently being done.

Jan