atom feed6 messages in org.kde.rekonqRe: [rekonq] Review Request: Fix tab ...
FromSent OnAttachments
Yoann LaissusSep 17, 2011 1:27 pm 
Andrea DiamantiniSep 18, 2011 2:44 pm 
Andrea DiamantiniSep 18, 2011 2:47 pm 
Yoann LaissusSep 19, 2011 1:56 pm 
Andrea DiamantiniSep 20, 2011 1:13 am 
Commit HookSep 20, 2011 8:58 am 
Subject:Re: [rekonq] Review Request: Fix tab size and addTabButton position with a KMessageWidget
From:Commit Hook (nu@kde.org)
Date:Sep 20, 2011 8:58:32 am
List:org.kde.rekonq

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102651/#review6682

-----------------------------------------------------------

This review has been submitted with commit
5ba5ca480db1eb14fa1163ce5ac1640f66125b21 by Yoann Laissus to branch master.

- Commit

On Sept. 19, 2011, 8:56 p.m., Yoann Laissus wrote:

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102651/

-----------------------------------------------------------

(Updated Sept. 19, 2011, 8:56 p.m.)

Review request for rekonq.

Summary

-------

When a KMessageWidget appears, the sizeHint width of the MainView grows up a
lot. So it produces bigger tabs with an incorrect position of the addTabButton. (eg:
Try to log in to Gmail)

I fixed this issue by setting a fixed max value for tab width. (MainView default
width without a KMessageWidget) I haven't found a cleaner way to do that. I also removed a check which broke the addTabButton position in MainView.

Branch : git://anongit.kde.org/clones/rekonq/laissus/rekonq-clone.git fixTabSize

Diffs

-----

src/mainview.h ce17a77 src/mainview.cpp 716e8da src/tabbar.cpp 2c28573

Diff: http://git.reviewboard.kde.org/r/102651/diff

Testing

Thanks,