atom feed26 messages in org.freebsd.freebsd-archRe: unix domain sockets on nullfs(5)
FromSent OnAttachments
Mikolaj GolubJan 9, 2012 8:37 am.patch
Alfred PerlsteinJan 9, 2012 9:23 am 
John BaldwinJan 10, 2012 5:18 am 
Robert N. M. WatsonJan 10, 2012 6:02 am 
Mikolaj GolubJan 10, 2012 12:09 pm 
Mikolaj GolubJan 10, 2012 12:29 pm 
Mikolaj GolubJan 12, 2012 1:17 pm 
Kostik BelousovJan 12, 2012 1:29 pm 
Robert N. M. WatsonJan 12, 2012 1:39 pm 
Kris MooreJan 12, 2012 1:42 pm 
Kostik BelousovJan 12, 2012 1:50 pm 
Mikolaj GolubJan 22, 2012 10:33 am 
Kostik BelousovJan 22, 2012 7:12 pm 
Mikolaj GolubFeb 18, 2012 1:21 pm 
Konstantin BelousovFeb 18, 2012 1:49 pm 
Mikolaj GolubFeb 18, 2012 2:26 pm 
Mikolaj GolubFeb 19, 2012 1:54 am 
Konstantin BelousovFeb 19, 2012 9:01 am 
Mikolaj GolubFeb 20, 2012 1:02 am 
Konstantin BelousovFeb 20, 2012 2:08 am 
Mikolaj GolubFeb 25, 2012 2:59 am 
Konstantin BelousovFeb 25, 2012 9:47 am 
Robert N. M. WatsonFeb 25, 2012 11:15 am 
Mikolaj GolubApr 22, 2012 6:36 am.diff
Konstantin BelousovApr 22, 2012 9:08 am 
Mikolaj GolubApr 24, 2012 12:16 pm 
Subject:Re: unix domain sockets on nullfs(5)
From:Kris Moore (kr@pcbsd.org)
Date:Jan 12, 2012 1:42:45 pm
List:org.freebsd.freebsd-arch

On 01/12/2012 16:39, Robert N. M. Watson wrote:

On 12 Jan 2012, at 21:17, Mikolaj Golub wrote:

If we agree to have only the new behavior then nullfs won't need modification at all, it will work as expected automatically. The patch could be (with updated locking for the connect case):

http://people.freebsd.org/~trociny/VOP_UNP.1.patch

Greatly simplified.

--- sys/kern/uipc_usrreq.c (revision 229979) +++ sys/kern/uipc_usrreq.c (working copy) @@ -542,7 +542,7 @@

UNP_LINK_WLOCK(); UNP_PCB_LOCK(unp); - vp->v_socket = unp->unp_socket; + VOP_UNPBIND(vp, unp->unp_socket); unp->unp_vnode = vp; unp->unp_addr = soun; unp->unp_flags &= ~UNP_BINDING;

I still find myself worried by the fact that unp->unp_vnode points at the nullfs
vnode rather than the underlying vnode, but haven't yet managed to identify any
actual bugs that would result. I'll continue pondering it over the weekend :-).

Robert_______________________________________________ free@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-arch To unsubscribe, send any mail to "free@freebsd.org"

FYI - Not sure if this helps, but we've been using this patch to expose sockets in the lower layer for 2+ years now, haven't run into any issues as of yet.

http://trac.pcbsd.org/browser/pcbsd/current/build-files/src-patches/nullfs-patch