11 messages in org.freebsd.freebsd-currentRe: Junior Kernel Hacker Task: M_ZERO| From | Sent On | Attachments |
|---|---|---|
| Poul-Henning Kamp | Oct 20, 2000 12:12 pm | |
| Robert Drehmel | Oct 20, 2000 6:08 pm | |
| Andrea Campi | Oct 21, 2000 6:15 am | |
| Garrett Rooney | Oct 21, 2000 6:48 am | |
| David Malone | Oct 21, 2000 12:16 pm | |
| Poul-Henning Kamp | Oct 21, 2000 10:06 pm | |
| David Malone | Oct 22, 2000 10:54 am | |
| Jesper Skriver | Oct 22, 2000 12:07 pm | |
| David Malone | Oct 22, 2000 2:47 pm | |
| Peter Dufault | Oct 22, 2000 3:23 pm | |
| Peter van Dijk | Oct 22, 2000 3:31 pm |
| Subject: | Re: Junior Kernel Hacker Task: M_ZERO | |
|---|---|---|
| From: | David Malone (dwma...@maths.tcd.ie) | |
| Date: | Oct 21, 2000 12:16:52 pm | |
| List: | org.freebsd.freebsd-current | |
On Sat, Oct 21, 2000 at 09:48:47AM -0400, Garrett Rooney wrote:
If anybody is looking for a simple task to perform in the FreeBSD kernel: this is it.
A quick grep tells me that there are at least 91 files in the src/sys tree which could use this flag to simplify and optimize the code.
i'll probably start looking at these this week sometime...
something to pass the time in class i suppose.
Before anyone else starts looking at this, I've collected and cleaned up the patches I've recieved so far and produced a big diff at:
http://www.maths.tcd.ie/~dwmalone/thirdtry
If you do find more of these remember to make sure the style in which you make the patch matches the surounding code. Also, please submit unified diffs - they are much easier to review for changes like this. If you can, make sure the code compiles before submitting it.
Other than style changes, I've included a list of other changes I've made to the submitted patches.
David.
sys/dev/aic7xxx/aic7xxx_freebsd.c Missing , in call to malloc in the patch.
sys/alpha/alpha/busdma_machdep.c sys/ia64/ia64/busdma_machdep.c Replace a sizeof(**mapp) with sizeof(*map) - they are the same but the second makes more sense. (this was in original code)
sys/dev/usb/ohci.c sys/dev/usb/uhci.c Fix one bug in patch where xfer would not be zeroed if it came off the free list.
sys/i386/include/mutex.h Patch reverted one of jhb's changes.
sys/i386/isa/cx.c Changes were in code not used by FreeBSD, so I removed them. (There was also a syntax error in the patch).
sys/kern/vfs_cache.c Patch zeroed more memory than original code - stick with original.
sys/netinet/ip_dummynet.c Preserve some comments that were removed by patch.
sys/netipx/ipx.c sys/netns/ns.c sizeof(*oia) and sizeof(*ia) not obviously the same - stick with original code.
To Unsubscribe: send mail to majo...@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message