[Xen-devel] misleading names in xen memory management code - Li, Xin B - com.xensource.lists.xen-devel

2 messages in com.xensource.lists.xen-devel[Xen-devel] misleading names in xen m...

From	Sent On	Attachments
Li, Xin B	28 Oct 2005 19:02
Ian Pratt	28 Oct 2005 19:25

Subject:	[Xen-devel] misleading names in xen memory management code
From:	Li, Xin B (xin....@intel.com)
Date:	10/28/2005 07:02:57 PM
List:	com.xensource.lists.xen-devel

Keir, I think we have some misleading names in xen memory management code: 1) #define page_to_pfn(_page) ((unsigned long)((_page) - frame_table)) Actually, it should be page_to_mfn.

2) #define l1e_from_pfn(pfn, flags) \ ((l1_pgentry_t) { ((intpte_t)(pfn) << PAGE_SHIFT) | put_pte_flags(flags) }) Seems l1e_from_mfn(mfn, flags) is much more clear.

Am I right?

-Xin