3 messages in com.perforce.perforce-user[p4] Code reviews with perforce| From | Sent On | Attachments |
|---|---|---|
| Richard Ramos | 18 Sep 2003 12:32 | |
| Noel Yap | 18 Sep 2003 12:57 | |
| Grills, Jeff | 18 Sep 2003 13:30 |
| Subject: | [p4] Code reviews with perforce |
|---|---|
| From: | Grills, Jeff (jgri...@soe.sony.com) |
| Date: | 09/18/2003 01:30:25 PM |
| List: | com.perforce.perforce-user |
We have a set of tools called p4tar and p4untar which will package up unsubmitted changelists and extract them on other machines. A programmer can quite send a changelist to a lead for review before submitting.
We also have a p4 trigger in place for specific areas of our code tree that need to be protected from access without lead permission. The p4 trigger will check the submit comments for a particular numeric code, and if it's not found, it'll reject the submit. If it is found, it will change the code to a new random number. We store that code in a p4 counter.
j
-----Original Message----- From: Noel Yap [mailto:Noel.Yap at morganstanley.com] Sent: Thursday, September 18, 2003 2:58 PM To: Richard Ramos Cc: perforce-user at perforce.com Subject: Re: [p4] Code reviews with perforce
IMHO, the best way to do this would be to have people submit onto task branches. An integrator would then evaluate what's on the branch and integrate it onto an integration branch if it's deemed worthy.
It's not exactly code reviews before the submit, but it might be better overall.
If you really want code reviews before submission, you might be able to use triggers to enforce permissioning that's given on a per-submit basis. For example, a reviewer would perform the code review, then grant permissions for the developer to submit the files just reviewed.
MTC, Noel
Richard Ramos wrote:
Can someone recommend a good way to help automate code reviews in perforce. The situation is that we've got developers running on different machines and I'd like to make use of perforce's graphical diff tool to inspect the changes before approving a submit.
Thanks.
Richard Ramos Elite Communications Inc. voice: 732-817-1600 x14 fax: 732-817-1601
_______________________________________________ perforce-user mailing list - perforce-user at perforce.com http://maillist.perforce.com/mailman/listinfo/perforce-user
-- NOTICE: If received in error, please destroy and notify sender. Sender does not waive confidentiality or privilege, and use is prohibited.
_______________________________________________ perforce-user mailing list - perforce-user at perforce.com http://maillist.perforce.com/mailman/listinfo/perforce-user