| From | Sent On | Attachments |
|---|---|---|
| Martin Makundi | Nov 4, 2010 1:13 pm | |
| 7zark7 | Nov 4, 2010 1:54 pm | |
| Jonathan Locke | Nov 4, 2010 3:06 pm | |
| Martin Makundi | Nov 4, 2010 3:08 pm | |
| Martin Makundi | Nov 4, 2010 3:13 pm | |
| Jeremy Thomerson | Nov 4, 2010 9:56 pm | |
| Martin Makundi | Nov 4, 2010 10:59 pm | |
| Martin Makundi | Nov 4, 2010 11:46 pm | |
| Michał Letyński | Nov 5, 2010 12:52 am | |
| Martin Makundi | Nov 5, 2010 1:07 am | |
| Martin Grigorov | Nov 5, 2010 1:12 am | |
| Martin Makundi | Nov 5, 2010 1:15 am | |
| Martin Grigorov | Nov 5, 2010 1:20 am | |
| Marc Nuri San Félix | Nov 5, 2010 1:22 am | |
| Martin Makundi | Nov 5, 2010 1:28 am | |
| Martin Makundi | Nov 5, 2010 1:31 am | |
| Martin Grigorov | Nov 5, 2010 1:34 am | |
| Martin Grigorov | Nov 5, 2010 1:36 am | |
| Martin Makundi | Nov 5, 2010 1:37 am | |
| Martin Makundi | Nov 5, 2010 1:38 am | |
| Martin Makundi | Nov 5, 2010 1:40 am | |
| Leszek Gawron | Nov 5, 2010 5:36 am | |
| James Carman | Nov 5, 2010 5:39 am | |
| Martin Makundi | Nov 5, 2010 5:47 am | |
| Igor Vaynberg | Nov 5, 2010 9:55 am | |
| Jeremy Thomerson | Nov 5, 2010 10:00 am | |
| Martin Makundi | Nov 5, 2010 10:23 am | |
| Igor Vaynberg | Nov 5, 2010 11:19 am | |
| Martin Makundi | Nov 5, 2010 11:39 am | |
| Eelco Hillenius | Nov 5, 2010 11:49 am | |
| Eelco Hillenius | Nov 5, 2010 11:56 am | |
| Martin Makundi | Nov 5, 2010 11:58 am | |
| Martin Makundi | Nov 5, 2010 12:00 pm | |
| Eelco Hillenius | Nov 5, 2010 12:15 pm | |
| Igor Vaynberg | Nov 5, 2010 12:55 pm | |
| Brian Topping | Nov 5, 2010 12:56 pm | |
| Martin Makundi | Nov 5, 2010 1:06 pm | |
| Martin Makundi | Nov 5, 2010 1:14 pm | |
| Igor Vaynberg | Nov 5, 2010 1:21 pm | |
| Brian Topping | Nov 5, 2010 1:32 pm | |
| Martin Makundi | Nov 5, 2010 10:05 pm | |
| Martin Makundi | Nov 5, 2010 10:07 pm | |
| Jeremy Thomerson | Nov 5, 2010 10:48 pm | |
| Martin Makundi | Nov 5, 2010 11:31 pm | |
| Igor Vaynberg | Nov 5, 2010 11:53 pm | |
| Martin Makundi | Nov 5, 2010 11:57 pm | |
| James Carman | Nov 6, 2010 5:12 am | |
| Martin Makundi | Nov 6, 2010 5:20 am | |
| Jeremy Thomerson | Nov 6, 2010 6:22 am | |
| Martin Makundi | Nov 6, 2010 6:43 am | |
| samket | Nov 6, 2010 6:54 am | |
| Igor Vaynberg | Nov 6, 2010 4:44 pm | |
| Sebastian | Nov 8, 2010 8:17 am | |
| Vitaly Tsaplin | Nov 8, 2010 8:23 am | |
| Igor Vaynberg | Nov 8, 2010 8:27 am | |
| Martin Makundi | Nov 8, 2010 8:29 am | |
| Igor Vaynberg | Nov 8, 2010 8:35 am | |
| Vitaly Tsaplin | Nov 8, 2010 8:35 am | |
| Martin Makundi | Nov 8, 2010 8:42 am | |
| Sebastian | Nov 8, 2010 8:51 am | |
| Martin Makundi | Nov 8, 2010 8:58 am | |
| Igor Vaynberg | Nov 8, 2010 8:58 am | |
| Igor Vaynberg | Nov 8, 2010 9:03 am | |
| Sebastian | Nov 8, 2010 9:07 am | |
| Martin Makundi | Nov 8, 2010 9:13 am | |
| Omid Milani | Nov 8, 2010 9:31 am | |
| Igor Vaynberg | Nov 8, 2010 9:32 am | |
| Rodolfo Hansen | Nov 8, 2010 10:01 am | |
| Eelco Hillenius | Nov 8, 2010 10:22 pm | |
| Martin Makundi | Nov 8, 2010 10:39 pm | |
| Martin Makundi | Nov 8, 2010 10:40 pm | |
| Carl-Eric Menzel | Nov 9, 2010 12:15 am | |
| Martin Makundi | Nov 9, 2010 12:19 am | |
| Martin Makundi | Nov 9, 2010 12:23 am | |
| Carl-Eric Menzel | Nov 9, 2010 12:41 am | |
| Carl-Eric Menzel | Nov 9, 2010 12:44 am | |
| Martin Makundi | Nov 9, 2010 1:01 am | |
| Carl-Eric Menzel | Nov 9, 2010 4:12 am | |
| Martin Makundi | Nov 9, 2010 4:21 am | |
| Vitaly Tsaplin | Nov 9, 2010 4:29 am | |
| Martin Makundi | Nov 9, 2010 4:34 am | |
| Matthias Keller | Nov 9, 2010 4:46 am | |
| manuelbarzi | Nov 9, 2010 4:49 am | |
| James Carman | Nov 9, 2010 4:49 am | |
| Martin Makundi | Nov 9, 2010 4:54 am | |
| James Carman | Nov 9, 2010 4:57 am | |
| Martin Makundi | Nov 9, 2010 4:58 am | |
| manuelbarzi | Nov 9, 2010 5:26 am | |
| Martin Makundi | Nov 9, 2010 5:48 am | |
| Frank Silbermann | Nov 9, 2010 6:46 am | |
| Martin Grigorov | Nov 9, 2010 6:58 am | |
| Carl-Eric Menzel | Nov 9, 2010 7:02 am | |
| James Carman | Nov 9, 2010 7:05 am | |
| Carl-Eric Menzel | Nov 9, 2010 7:11 am | |
| Carl-Eric Menzel | Nov 9, 2010 7:14 am | |
| 121 later messages | ||
| Subject: | Re: Free wicket from component hierarchy hell | |
|---|---|---|
| From: | Igor Vaynberg (igor...@gmail.com) | |
| Date: | Nov 5, 2010 11:53:21 pm | |
| List: | org.apache.wicket.users | |
On Fri, Nov 5, 2010 at 11:32 PM, Martin Makundi <mart...@koodaripalvelut.com> wrote:
Hi!
Please make sure that it passes all current test cases before submitting the patch. Also, it would be good to take the examples that have been given to you in this thread and create tests from them that demonstrate that they all work. Particularly important will be demonstrating the security example that Igor gave above.
The security example is quite extreme and should be implemented in traditional way if there is no regression test for it.
there is nothing extreme about it, it is a common use of containers when implementing visibility/security. just the fact that this "forces" the traditional approach sounds scarry.
-igor
I'm telling you all this in advance, not to be mean, but to help you out. In this one thread, you've pulled out more responses from PMC members and committers than any thread in recent memory - and all of them agreed that it was a bad idea, and not likely to be implemented. So, if you submit a patch, it needs to meet all the above criteria to prove us all wrong. I'd rather tell you that up front than have you submit a half-working patch and then get shot down in a blaze of glory. :)
I am planning to take more of a "helper method" approach that is not so invasive:
HierarchyUtils.helpMeAddThisComponentToItsParent(panel, component);
** Martin
-- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org*





