atom feed216 messages in org.apache.wicket.usersRe: Free wicket from component hierar...
FromSent OnAttachments
Martin MakundiNov 4, 2010 1:13 pm 
7zark7Nov 4, 2010 1:54 pm 
Jonathan LockeNov 4, 2010 3:06 pm 
Martin MakundiNov 4, 2010 3:08 pm 
Martin MakundiNov 4, 2010 3:13 pm 
Jeremy ThomersonNov 4, 2010 9:56 pm 
Martin MakundiNov 4, 2010 10:59 pm 
Martin MakundiNov 4, 2010 11:46 pm 
Michał LetyńskiNov 5, 2010 12:52 am 
Martin MakundiNov 5, 2010 1:07 am 
Martin GrigorovNov 5, 2010 1:12 am 
Martin MakundiNov 5, 2010 1:15 am 
Martin GrigorovNov 5, 2010 1:20 am 
Marc Nuri San FélixNov 5, 2010 1:22 am 
Martin MakundiNov 5, 2010 1:28 am 
Martin MakundiNov 5, 2010 1:31 am 
Martin GrigorovNov 5, 2010 1:34 am 
Martin GrigorovNov 5, 2010 1:36 am 
Martin MakundiNov 5, 2010 1:37 am 
Martin MakundiNov 5, 2010 1:38 am 
Martin MakundiNov 5, 2010 1:40 am 
Leszek GawronNov 5, 2010 5:36 am 
James CarmanNov 5, 2010 5:39 am 
Martin MakundiNov 5, 2010 5:47 am 
Igor VaynbergNov 5, 2010 9:55 am 
Jeremy ThomersonNov 5, 2010 10:00 am 
Martin MakundiNov 5, 2010 10:23 am 
Igor VaynbergNov 5, 2010 11:19 am 
Martin MakundiNov 5, 2010 11:39 am 
Eelco HilleniusNov 5, 2010 11:49 am 
Eelco HilleniusNov 5, 2010 11:56 am 
Martin MakundiNov 5, 2010 11:58 am 
Martin MakundiNov 5, 2010 12:00 pm 
Eelco HilleniusNov 5, 2010 12:15 pm 
Igor VaynbergNov 5, 2010 12:55 pm 
Brian ToppingNov 5, 2010 12:56 pm 
Martin MakundiNov 5, 2010 1:06 pm 
Martin MakundiNov 5, 2010 1:14 pm 
Igor VaynbergNov 5, 2010 1:21 pm 
Brian ToppingNov 5, 2010 1:32 pm 
Martin MakundiNov 5, 2010 10:05 pm 
Martin MakundiNov 5, 2010 10:07 pm 
Jeremy ThomersonNov 5, 2010 10:48 pm 
Martin MakundiNov 5, 2010 11:31 pm 
Igor VaynbergNov 5, 2010 11:53 pm 
Martin MakundiNov 5, 2010 11:57 pm 
James CarmanNov 6, 2010 5:12 am 
Martin MakundiNov 6, 2010 5:20 am 
Jeremy ThomersonNov 6, 2010 6:22 am 
Martin MakundiNov 6, 2010 6:43 am 
samketNov 6, 2010 6:54 am 
Igor VaynbergNov 6, 2010 4:44 pm 
SebastianNov 8, 2010 8:17 am 
Vitaly TsaplinNov 8, 2010 8:23 am 
Igor VaynbergNov 8, 2010 8:27 am 
Martin MakundiNov 8, 2010 8:29 am 
Igor VaynbergNov 8, 2010 8:35 am 
Vitaly TsaplinNov 8, 2010 8:35 am 
Martin MakundiNov 8, 2010 8:42 am 
SebastianNov 8, 2010 8:51 am 
Martin MakundiNov 8, 2010 8:58 am 
Igor VaynbergNov 8, 2010 8:58 am 
Igor VaynbergNov 8, 2010 9:03 am 
SebastianNov 8, 2010 9:07 am 
Martin MakundiNov 8, 2010 9:13 am 
Omid MilaniNov 8, 2010 9:31 am 
Igor VaynbergNov 8, 2010 9:32 am 
Rodolfo HansenNov 8, 2010 10:01 am 
Eelco HilleniusNov 8, 2010 10:22 pm 
Martin MakundiNov 8, 2010 10:39 pm 
Martin MakundiNov 8, 2010 10:40 pm 
Carl-Eric MenzelNov 9, 2010 12:15 am 
Martin MakundiNov 9, 2010 12:19 am 
Martin MakundiNov 9, 2010 12:23 am 
Carl-Eric MenzelNov 9, 2010 12:41 am 
Carl-Eric MenzelNov 9, 2010 12:44 am 
Martin MakundiNov 9, 2010 1:01 am 
Carl-Eric MenzelNov 9, 2010 4:12 am 
Martin MakundiNov 9, 2010 4:21 am 
Vitaly TsaplinNov 9, 2010 4:29 am 
Martin MakundiNov 9, 2010 4:34 am 
Matthias KellerNov 9, 2010 4:46 am 
manuelbarziNov 9, 2010 4:49 am 
James CarmanNov 9, 2010 4:49 am 
Martin MakundiNov 9, 2010 4:54 am 
James CarmanNov 9, 2010 4:57 am 
Martin MakundiNov 9, 2010 4:58 am 
manuelbarziNov 9, 2010 5:26 am 
Martin MakundiNov 9, 2010 5:48 am 
Frank SilbermannNov 9, 2010 6:46 am 
Martin GrigorovNov 9, 2010 6:58 am 
Carl-Eric MenzelNov 9, 2010 7:02 am 
James CarmanNov 9, 2010 7:05 am 
Carl-Eric MenzelNov 9, 2010 7:11 am 
Carl-Eric MenzelNov 9, 2010 7:14 am 
121 later messages
Subject:Re: Free wicket from component hierarchy hell
From:Igor Vaynberg (igor@gmail.com)
Date:Nov 5, 2010 11:53:21 pm
List:org.apache.wicket.users

On Fri, Nov 5, 2010 at 11:32 PM, Martin Makundi <mart@koodaripalvelut.com> wrote:

Hi!

Please make sure that it passes all current test cases before submitting the patch.  Also, it would be good to take the examples that have been given to you in this thread and create tests from them that demonstrate that they all work.  Particularly important will be demonstrating the security example that Igor gave above.

The security example is quite extreme and should be implemented in traditional way if there is no regression test for it.

there is nothing extreme about it, it is a common use of containers when implementing visibility/security. just the fact that this "forces" the traditional approach sounds scarry.

-igor

I'm telling you all this in advance, not to be mean, but to help you out. In this one thread, you've pulled out more responses from PMC members and committers than any thread in recent memory - and all of them agreed that it was a bad idea, and not likely to be implemented.  So, if you submit a patch, it needs to meet all the above criteria to prove us all wrong.  I'd rather tell you that up front than have you submit a half-working patch and then get shot down in a blaze of glory.  :)

I am planning to take more of a "helper method" approach that is not so invasive:

HierarchyUtils.helpMeAddThisComponentToItsParent(panel, component);

** Martin