8 messages in com.mysql.lists.eventum-usersRe: Patch (was: Adding attachments to...
FromSent OnAttachments
Chris Davis04 Mar 2008 15:31 
Harri Porten04 Mar 2008 23:20 
Harri Porten12 Mar 2008 13:25.diff
Elan Ruusamäe14 Mar 2008 06:06 
Harri Porten14 Mar 2008 08:15 
Elan Ruusamäe25 Mar 2008 04:08 
Elan Ruusamäe25 Mar 2008 04:16 
Chris Davis25 Mar 2008 11:21 
Subject:Re: Patch (was: Adding attachments to outgoing messages)
From:Chris Davis (cda@preterit.com)
Date:03/25/2008 11:21:22 AM
List:com.mysql.lists.eventum-users

Hi again,

I've posted my altered version if anyone is interested. (Comments/critiques would be welcome.)

http://cpdavis.com/wiki/Eventum

This version is different from Harri's in that it looks for files already attached to the ticket and allows the user to forward them on when sending email. I've been running it for the past two weeks and haven't received any bug reports from users. The zip archive contains the complete files. Search for "Attachments!" within comment tags to see the relevant modifications.

Thanks,

-c-

On Tue, Mar 25, 2008 at 6:16 AM, Elan Ruusamäe <gl@delfi.ee> wrote:

On Tuesday 25 March 2008 13:08:53 Elan Ruusamäe wrote:

On Friday 14 March 2008 17:16:00 Harri Porten wrote:

Hello Elan,

On Fri, 14 Mar 2008, Elan Ruusamäe wrote:

On Wednesday 12 March 2008 22:26:15 Harri Porten wrote:

Would be great if the Eventum developers would consider implementing such a feature.

ok your patch is buggy some part was not updated:

2008-03-25 12:54:43: (mod_fastcgi.c.2592) FastCGI-stderr: PHP Warning: Missing argument 9 for Support::buildFullHeaders(), called in /usr/share/eventum/include/class.issue.php on line 1339 and defined in /usr/share/eventum/include/class.support.php on line 1930PHP Notice: Undefined variable: attachment in /usr/share/eventum/include/class.support.php on line 1949

fixed now in svn

$ svn ci -m '- bugfix for Harri Porten attachment patch' Sending include/class.support.php Transmitting file data . Committed revision 3558.