atom feed5 messages in org.kernel.vger.kernel-janitorsRe: [PATCH v2] MIPS: Fix incorrect NU...
FromSent OnAttachments
Emil GoodeJul 5, 2014 11:26 am 
Jonas GorskiJul 5, 2014 12:10 pm 
Emil GoodeJul 5, 2014 3:50 pm 
Maciej W. RozyckiJul 6, 2014 4:16 am 
Emil GoodeJul 6, 2014 3:13 pm 
Subject:Re: [PATCH v2] MIPS: Fix incorrect NULL check in local_flush_tlb_page()
From:Jonas Gorski (jo@openwrt.org)
Date:Jul 5, 2014 12:10:44 pm
List:org.kernel.vger.kernel-janitors

On Sat, Jul 5, 2014 at 8:26 PM, Emil Goode <emil@gmail.com> wrote:

We check that the struct vm_area_struct pointer vma is NULL and then dereference it a few lines below. The intent must have been to make sure that vma is not NULL and then to check the value from cpu_context() for the condition to be true.

Signed-off-by: Emil Goode <emil@gmail.com>

---

v2: Updated the commit message with a better explanation.

arch/mips/mm/tlb-r3k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/mm/tlb-r3k.c b/arch/mips/mm/tlb-r3k.c index d657493..6546758 100644 --- a/arch/mips/mm/tlb-r3k.c +++ b/arch/mips/mm/tlb-r3k.c @@ -158,7 +158,7 @@ void local_flush_tlb_page(struct vm_area_struct *vma,
unsigned long page) { int cpu = smp_processor_id();

- if (!vma || cpu_context(cpu, vma->vm_mm) != 0) { + if (vma && cpu_context(cpu, vma->vm_mm) != 0) {

Sorry for replying "too late", but grepping through the kernel code I fail to find any caller that does not dereference vma before calling (local)flush_tlb_page(). Also both tlb-4k and tlb-8k assume vma cannot be NULL, so I would say it is safe to assume vma is never NULL, and the NULL check can be removed completely.

Also it looks like this "bug" was there since at least 2.6.12, and never seem to have bitten anyone.

Jonas