| From | Sent On | Attachments |
|---|---|---|
| 54 earlier messages | ||
| Konrad Rzeszutek Wilk | Oct 20, 2009 9:57 am | .patch |
| Pasi Kärkkäinen | Oct 21, 2009 4:53 am | |
| Konrad Rzeszutek Wilk | Oct 21, 2009 11:31 am | |
| Pasi Kärkkäinen | Oct 21, 2009 11:51 am | |
| Jeremy Fitzhardinge | Oct 21, 2009 12:49 pm | |
| Pasi Kärkkäinen | Oct 21, 2009 1:21 pm | |
| Pasi Kärkkäinen | Oct 27, 2009 8:46 am | |
| Konrad Rzeszutek Wilk | Oct 27, 2009 9:59 am | .makefile, .c |
| Pasi Kärkkäinen | Oct 27, 2009 10:29 am | |
| Konrad Rzeszutek Wilk | Oct 27, 2009 12:40 pm | |
| Pasi Kärkkäinen | Oct 27, 2009 12:45 pm | |
| Konrad Rzeszutek Wilk | Oct 27, 2009 1:12 pm | |
| Pasi Kärkkäinen | Oct 27, 2009 1:17 pm | |
| Pasi Kärkkäinen | Oct 27, 2009 1:23 pm | |
| Pasi Kärkkäinen | Oct 27, 2009 1:35 pm | |
| Jeremy Fitzhardinge | Nov 11, 2009 4:46 pm | |
| Jeremy Fitzhardinge | Nov 11, 2009 4:59 pm | |
| Jeremy Fitzhardinge | Nov 12, 2009 3:50 pm | |
| Zhang, Xiantao | Nov 12, 2009 9:26 pm | |
| Keir Fraser | Nov 12, 2009 11:24 pm | |
| Jeremy Fitzhardinge | Nov 13, 2009 3:56 pm | |
| Keir Fraser | Nov 14, 2009 12:04 am | |
| Zhang, Xiantao | Nov 16, 2009 2:37 am | .patch, .patch |
| Jeremy Fitzhardinge | Nov 16, 2009 10:37 am | |
| Zhang, Xiantao | Nov 16, 2009 7:12 pm | |
| Keir Fraser | Nov 16, 2009 7:44 pm | |
| Jeremy Fitzhardinge | Nov 16, 2009 9:12 pm | |
| Jeremy Fitzhardinge | Nov 16, 2009 9:19 pm | |
| Keir Fraser | Nov 16, 2009 9:43 pm | |
| Zhang, Xiantao | Nov 17, 2009 4:45 am | .patch |
| Keir Fraser | Nov 17, 2009 5:04 am | |
| Zhang, Xiantao | Nov 17, 2009 6:16 am | |
| Jeremy Fitzhardinge | Nov 17, 2009 10:50 am | |
| Keir Fraser | Nov 17, 2009 11:49 am | |
| Jiang, Yunhong | Nov 17, 2009 7:11 pm | |
| Zhang, Xiantao | Nov 17, 2009 7:24 pm | |
| Zhang, Xiantao | Nov 17, 2009 7:37 pm | |
| Keir Fraser | Nov 18, 2009 1:36 am | |
| Konrad Rzeszutek Wilk | Nov 18, 2009 6:14 am | |
| Konrad Rzeszutek Wilk | Nov 18, 2009 6:29 am | |
| Zhang, Xiantao | Nov 19, 2009 5:45 pm | |
| Zhang, Xiantao | Nov 19, 2009 5:47 pm | |
| Zhang, Xiantao | Nov 24, 2009 2:04 am | .patch, .patch |
| Jeremy Fitzhardinge | Nov 24, 2009 11:25 am | |
| Konrad Rzeszutek Wilk | Nov 24, 2009 11:43 am | |
| Jeremy Fitzhardinge | Nov 24, 2009 3:34 pm | |
| Zhang, Xiantao | Nov 24, 2009 5:41 pm | |
| Zhang, Xiantao | Nov 24, 2009 6:43 pm | |
| Konrad Rzeszutek Wilk | Nov 25, 2009 5:41 am | |
| Konrad Rzeszutek Wilk | Nov 25, 2009 6:09 am | |
| Zhang, Xiantao | Nov 25, 2009 7:21 am | |
| Konrad Rzeszutek Wilk | Nov 25, 2009 10:00 am | |
| Jeremy Fitzhardinge | Nov 25, 2009 10:58 am | |
| Jeremy Fitzhardinge | Nov 25, 2009 11:13 am | |
| Zhang, Xiantao | Nov 25, 2009 5:11 pm | |
| Zhang, Xiantao | Nov 26, 2009 3:52 am | |
| Konrad Rzeszutek Wilk | Nov 30, 2009 6:26 am | |
| Konrad Rzeszutek Wilk | Nov 30, 2009 6:33 am | |
| Zhang, Xiantao | Dec 2, 2009 6:13 pm | |
| Konrad Rzeszutek Wilk | Dec 3, 2009 6:37 am | |
| Stefan Kuhne | Dec 4, 2009 8:07 am | |
| Pasi Kärkkäinen | Dec 4, 2009 10:57 am | |
| Jeremy Fitzhardinge | Dec 4, 2009 11:26 am | |
| Pasi Kärkkäinen | Jan 1, 2010 9:20 am | |
| Konrad Rzeszutek Wilk | Jan 4, 2010 5:37 am | |
| Pasi Kärkkäinen | Jan 4, 2010 11:41 am | |
| Konrad Rzeszutek Wilk | Jan 14, 2010 12:05 pm | |
| Pasi Kärkkäinen | Jan 14, 2010 11:18 pm | |
| Subject: | Re: [Xen-devel] Re: APIC rework | |
|---|---|---|
| From: | Konrad Rzeszutek Wilk (konr...@oracle.com) | |
| Date: | Nov 25, 2009 6:09:51 am | |
| List: | com.xensource.lists.xen-devel | |
On Tue, Nov 24, 2009 at 03:35:22PM -0800, Jeremy Fitzhardinge wrote:
On 11/24/09 11:44, Konrad Rzeszutek Wilk wrote:
At least dom0 parses this info from DSDT, so we can't have the assuption whether
it is used or not, I think. And I also agree to add a new physdev_op to handle
this case, and it should be better way to go.
Based on this idea, I worked out the patch, attached! In this patch, we
introduced a new physdev_op PHYSDEVOP_setup_gsi for each GSI setup, and each
domain can require to map each GSI in this case.
In addition, I believe it is very safe to port the hypervisor patch to xen-3.4-x
tree and keeps pv_ops dom0 running on it, since no logic is changed. BTW, I
also tested apic and non-apic cases, they works fine after applying the patches.
But I don't think you tested PCI front and PCI back.
Mainly these lines worry me (can you inline the patch next time too, please):
(Inline+attach, or an inline attachment rather than plain inline, is best. Plain inline with quoted-printable encoding is awkward to deal with.)
+ map_irq.domid = DOMID_SELF; + map_irq.type = MAP_PIRQ_TYPE_GSI; + map_irq.index = gsi; + map_irq.pirq = irq; + rc = HYPERVISOR_physdev_op(PHYSDEVOP_map_pirq, &map_irq);
For PCI passthrough to work, the domid needs to be for the guest domain, while in this case it is set to Dom0.
There is already a method of extracting the domain id for PCI devices passed to the guest. Look in the 'xen_create_msi_irq' function.
Hm, I'm not very keen on having xen_create_msi_irq do its own traversal of xenstore; it should take the domid as a parameter and its caller can do the walk if necessary. The direct call makes too much of a direct
It would be the easiest way. Unfortunatly the call sequence is the following:
pciback_do_op pciback_enable_msi (dev) ... arch_setup_msi_irqs ... arch_setup_msi_irq ... xen_setup_msi_irqs
The caller of the pciback_enable_msi knows of the domain id, but the rest
of the stack does not. One way of doing this is to provide hooks in event.c,
say:
[de|]register_msi_owner
(this is akin to how it was done in 2.6.18.hg)
where the device is associated with a specific domain id. We would call those register/deregister when a new device has changed ownership to a domain.
Back to the call trace. When we reach xen_setup_msi_irqs we can find the
relation.
Lookup the device (on this 'registration list') and see if it is assigned to a
specific domain.
But in essence it is similar in spirit to the mechanism of the xenbus_walk - that is to find out what domain id is associated with this device.
With the patches posted by Xiantao this behavior would have to be emulated for PCI INTx devices as well, or some flavour of it.
So the question is, Jeremy, would you prefer to have a
'[de|]register_device_owner'
call that both MSI and INTx can use and some way of traversing the list this
creates and finding out if there is an owner for the device? Or just leave
it with the xenbus_walk interface?
_______________________________________________ Xen-devel mailing list Xen-...@lists.xensource.com http://lists.xensource.com/xen-devel






.patch