atom feed8 messages in com.redhat.et-mgmt-toolsRe: [et-mgmt-tools] [PATCH]: virt-man...
FromSent OnAttachments
Guido GüntherSep 25, 2008 3:54 am.diff
Cole RobinsonSep 29, 2008 8:43 am 
Daniel P. BerrangeOct 1, 2008 2:46 am 
Guido GüntherOct 2, 2008 6:21 am 
Cole RobinsonOct 2, 2008 6:48 am 
Daniel P. BerrangeOct 2, 2008 7:35 am 
Guido GüntherOct 2, 2008 8:11 am.diff
Guido GüntherOct 2, 2008 5:44 pm.diff
Subject:Re: [et-mgmt-tools] [PATCH]: virt-manager: start network before vm creation
From:Cole Robinson (crob@redhat.com)
Date:Oct 2, 2008 6:48:09 am
List:com.redhat.et-mgmt-tools

Guido Günther wrote:

On Wed, Oct 01, 2008 at 10:46:41AM +0100, Daniel P. Berrange wrote: [..snip..]

Yep, as you say, there're two problems here. When creating the VM we need to make it clear which networks are active, and which are not - but still allow selection of an inactive network.

When starting a VM, we need to check fi the network is active. If it is not, we should popup a confirmation dialog informing the user, and /asking/ if we should automatically start the network at this time.

Attached patch does just this - inactive networks are postfixed with " (Inactive)" and when leaving the tab you're asked if you want to start the newtork.

Looks like you forgot to attach it :)

I'd split this into two but there doesn't seem to be a hg equivalient of "git rebase -i; git reset HEAD^; git add -p" - so splitting patches is much more cumbersome or am I missing something?

I think my hg workflow is pretty rudimentary so I'm not sure, sorry.

Thanks, Cole