atom feed6 messages in org.apache.wicket.devRe: Deprecate Component#onMarkupAttac...
FromSent OnAttachments
Martin GrigorovJan 31, 2012 8:44 am 
Igor VaynbergJan 31, 2012 9:17 am 
Martijn DashorstJan 31, 2012 9:37 am 
Christoph LeiterJan 31, 2012 9:50 am 
Martijn DashorstJan 31, 2012 12:25 pm 
Sven MeierJan 31, 2012 2:47 pm 
Subject:Re: Deprecate Component#onMarkupAttached() ?
From:Martijn Dashorst (mart@gmail.com)
Date:Jan 31, 2012 9:37:57 am
List:org.apache.wicket.dev

On Tue, Jan 31, 2012 at 5:44 PM, Martin Grigorov <mgri@apache.org> wrote:

Now I think Component#onMarkupAttached() becomes obsolete. #onInitialize() serves the same purpose, Should we deprecate it in 1.5.x and remove it in 6.0 ?

AFAIK the proper way of deprecating would be to deprecate in 6.0 and remove in 7.0, if we are going to utilize semver.

That said, 1.5 doesn't use semver, #onMarkupAttached() seems like a method that is not often overridden in user code. In my workspace with about 1M lines of code, 1k pages and 10k Java files there is only one component that overrides the onMarkupAttached method: org.apache.wicket.MarkupContainer.

So +1 to deprecate 1.5.x and remove in 6.0

Martijn