|Jason Evans||Apr 4, 2012 9:56 pm|
|John Baldwin||Apr 5, 2012 6:32 am|
|Konstantin Belousov||Apr 5, 2012 10:52 am|
|Jason Evans||Apr 5, 2012 11:55 am|
|Konstantin Belousov||Apr 5, 2012 12:09 pm|
|Jason Evans||Apr 5, 2012 3:47 pm|
|David O'Brien||Apr 12, 2012 11:40 am|
|Jason Evans||Apr 12, 2012 1:19 pm|
|David O'Brien||Apr 13, 2012 3:42 pm|
|Jason Evans||Apr 13, 2012 7:34 pm|
|Doug Barton||Apr 20, 2012 10:33 am|
|Pedro Giffuni||Apr 20, 2012 11:17 am|
|Doug Barton||Apr 20, 2012 1:35 pm|
|Pedro Giffuni||Apr 20, 2012 2:13 pm|
|Doug Barton||Apr 20, 2012 2:56 pm|
|David O'Brien||Apr 20, 2012 5:32 pm|
|Pedro Giffuni||Apr 20, 2012 6:05 pm|
|Doug Barton||Apr 21, 2012 12:22 am|
|Pedro Giffuni||Apr 21, 2012 2:19 pm|
|From:||Jason Evans (jas...@canonware.com)|
|Date:||Apr 5, 2012 11:55:25 am|
On Apr 5, 2012, at 10:52 AM, Konstantin Belousov wrote:
On Wed, Apr 04, 2012 at 09:56:45PM -0700, Jason Evans wrote:
I have the current version of jemalloc integrated into libc as contrib/jemalloc:
* Are the symbol versioning specifications right, and are the compatibility symbols for _malloc_options and _malloc_message workable?
Why do you manually added __sys_compat() for the symbols ? My reading of the patch shows that you do not change the ABI, and symbols are still at FBSD_1.0 and even in Symbol.map. The 1.3 symbols have different names, without prepended '_' ? Please correct me if I am wrong, but it seems that the __sym_compat() magic is not needed.
The malloc_conf and malloc_message symbols are new to this version of jemalloc,
though they are similar in spirit to _malloc_options/_malloc_message.
_malloc_options/_malloc_message aren't actually supported by this version of
jemalloc, but the symbols still need to exist so that old applications that were
linked with previous releases can run. My intention with the __sys_compat()
macros was to make _malloc_options/_malloc_message available to those
applications, but to keep from exporting the symbols for use when linking new
applications. Is this the wrong thing to do, and/or do I misunderstand how
compat symbols work?
* Is the light editing of the jemalloc manual page sufficient? Keeping the changes minimal will make regular imports less work, but the result is less tailored to FreeBSD.
Might be, keep existing but somewhat trimmed malloc(3) page as is, but add the unedited man from contrib as jemalloc(3), xreferencing it from malloc(3) ?
Hmm, that's an interesting idea. My main concerns with it are the amount of
redundancy (everything in malloc(3) would be redundant), and the decreased
visibility of additional functionality in the documentation. The TUNING,
IMPLEMENTATION NOTES, DEBUGGING MALLOC PROBLEMS, and DIAGNOSTIC MESSAGES
sections would all be absent from malloc(3), thus requiring users to notice the
jemalloc(3) cross reference to find full documentation.
Thanks, Jason_______________________________________________ free...@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "free...@freebsd.org"