42 messages in org.freebsd.freebsd-fsRe: [review request] zfsboot/zfsloade...| From | Sent On | Attachments |
|---|---|---|
| Andriy Gapon | Apr 14, 2012 8:37 am | |
| Andriy Gapon | Apr 14, 2012 10:35 am | |
| Bob Friesenhahn | Apr 14, 2012 6:00 pm | |
| Garrett Cooper | Apr 14, 2012 7:30 pm | |
| John Baldwin | Apr 16, 2012 6:55 am | |
| vermaden | Apr 16, 2012 10:34 pm | |
| Andriy Gapon | Apr 17, 2012 1:21 pm | |
| John Baldwin | Apr 17, 2012 1:43 pm | |
| Andriy Gapon | Apr 17, 2012 11:01 pm | |
| Andriy Gapon | Apr 18, 2012 1:57 am | |
| Andriy Gapon | Apr 18, 2012 2:18 am | |
| John Baldwin | Apr 18, 2012 6:41 am | |
| Ian Lepore | Apr 18, 2012 7:22 am | |
| Andriy Gapon | Apr 18, 2012 7:36 am | |
| Ian Lepore | Apr 18, 2012 7:39 am | |
| Andriy Gapon | Apr 18, 2012 7:59 am | |
| John Baldwin | Apr 18, 2012 10:47 am | |
| Marius Strobl | Apr 22, 2012 2:20 pm | |
| Andrey V. Elsukov | Apr 22, 2012 11:23 pm | |
| Andriy Gapon | Apr 27, 2012 2:05 am | |
| Andriy Gapon | Apr 27, 2012 2:13 am | |
| Andrey V. Elsukov | Apr 27, 2012 3:37 am | |
| Andriy Gapon | Apr 27, 2012 7:06 am | |
| Marius Strobl | Apr 29, 2012 9:46 am | |
| Andriy Gapon | Apr 30, 2012 12:03 am | |
| Marius Strobl | May 1, 2012 1:20 pm | |
| Andriy Gapon | May 3, 2012 8:02 am | |
| Andriy Gapon | May 3, 2012 8:23 am | |
| John Baldwin | May 4, 2012 8:24 am | |
| Andriy Gapon | May 5, 2012 2:30 am | |
| Andriy Gapon | May 5, 2012 2:52 am | |
| Bruce Evans | May 5, 2012 3:49 am | |
| John Baldwin | May 7, 2012 6:52 am | |
| Andriy Gapon | May 7, 2012 7:34 am | |
| Andriy Gapon | May 7, 2012 7:46 am | |
| Andriy Gapon | May 7, 2012 8:15 am | |
| John Baldwin | May 7, 2012 10:37 am | |
| John Baldwin | May 7, 2012 10:43 am | |
| Andriy Gapon | May 8, 2012 12:14 am | |
| John Baldwin | May 8, 2012 7:15 am | |
| Andriy Gapon | May 8, 2012 11:34 am | |
| Andriy Gapon | May 11, 2012 3:31 pm |
| Subject: | Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool | |
|---|---|---|
| From: | John Baldwin (jh...@freebsd.org) | |
| Date: | May 7, 2012 10:43:22 am | |
| List: | org.freebsd.freebsd-fs | |
On Monday, May 07, 2012 10:47:05 am Andriy Gapon wrote:
on 07/05/2012 16:53 John Baldwin said the following:
On Saturday, May 05, 2012 5:53:07 am Andriy Gapon wrote:
[snip]
The new patchset: http://people.freebsd.org/~avg/zfsboot.patches.7.diff
Looks great, thanks! A few replies below:
Here's a followup patch for the suggestions: http://people.freebsd.org/~avg/bootargs.followup.diff I will merge it into the main patch.
What do you think about the -LOCORE- change that Bruce inspired?
In general I think this looks good. I have only one suggestion. In other code (e.g. the genassym constants in the kernel) where we define constants for field offsets, we make the constant be the uppercase name of the field itself (e.g. TD_PCB for offsetof(struct thread, td_pcb)). I would rather do that here as well. In this case the field names do not have a prefix, but let's just use a BA_ prefix for members of 'bootargs'. BI_SIZE is already correct, but this would mean renaming HT_OFF to BA_HOWTO, BF_OFF to BA_BOOTFLAGS, and BI_OFF to BA_BOOTINFO. I think you can probably leave BA_SIZE as-is.
Also, at some point we could use a genassym.c file ala the kernel builds to
generate
some of the constants in bootargs.h instead (e.g. the offsets of fields within
structures, and BA_SIZE, though we probably want to ensure that BA_SIZE never
changes).
The genassym approach sounds good, but, indeed - later :)
Yes, that can wait. I think it would not be very hard to do however. All you really need is access to sys/kern/genassym.sh and nm.
-- John Baldwin
_______________________________________________ free...@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-fs To unsubscribe, send any mail to "free...@freebsd.org"