atom feed216 messages in org.apache.wicket.usersRe: Free wicket from component hierar...
FromSent OnAttachments
16 earlier messages
Martin GrigorovNov 5, 2010 1:34 am 
Martin GrigorovNov 5, 2010 1:36 am 
Martin MakundiNov 5, 2010 1:37 am 
Martin MakundiNov 5, 2010 1:38 am 
Martin MakundiNov 5, 2010 1:40 am 
Leszek GawronNov 5, 2010 5:36 am 
James CarmanNov 5, 2010 5:39 am 
Martin MakundiNov 5, 2010 5:47 am 
Igor VaynbergNov 5, 2010 9:55 am 
Jeremy ThomersonNov 5, 2010 10:00 am 
Martin MakundiNov 5, 2010 10:23 am 
Igor VaynbergNov 5, 2010 11:19 am 
Martin MakundiNov 5, 2010 11:39 am 
Eelco HilleniusNov 5, 2010 11:49 am 
Eelco HilleniusNov 5, 2010 11:56 am 
Martin MakundiNov 5, 2010 11:58 am 
Martin MakundiNov 5, 2010 12:00 pm 
Eelco HilleniusNov 5, 2010 12:15 pm 
Igor VaynbergNov 5, 2010 12:55 pm 
Brian ToppingNov 5, 2010 12:56 pm 
Martin MakundiNov 5, 2010 1:06 pm 
Martin MakundiNov 5, 2010 1:14 pm 
Igor VaynbergNov 5, 2010 1:21 pm 
Brian ToppingNov 5, 2010 1:32 pm 
Martin MakundiNov 5, 2010 10:05 pm 
Martin MakundiNov 5, 2010 10:07 pm 
Jeremy ThomersonNov 5, 2010 10:48 pm 
Martin MakundiNov 5, 2010 11:31 pm 
Igor VaynbergNov 5, 2010 11:53 pm 
Martin MakundiNov 5, 2010 11:57 pm 
James CarmanNov 6, 2010 5:12 am 
Martin MakundiNov 6, 2010 5:20 am 
Jeremy ThomersonNov 6, 2010 6:22 am 
Martin MakundiNov 6, 2010 6:43 am 
samketNov 6, 2010 6:54 am 
Igor VaynbergNov 6, 2010 4:44 pm 
SebastianNov 8, 2010 8:17 am 
Vitaly TsaplinNov 8, 2010 8:23 am 
Igor VaynbergNov 8, 2010 8:27 am 
Martin MakundiNov 8, 2010 8:29 am 
Igor VaynbergNov 8, 2010 8:35 am 
Vitaly TsaplinNov 8, 2010 8:35 am 
Martin MakundiNov 8, 2010 8:42 am 
SebastianNov 8, 2010 8:51 am 
Martin MakundiNov 8, 2010 8:58 am 
Igor VaynbergNov 8, 2010 8:58 am 
Igor VaynbergNov 8, 2010 9:03 am 
SebastianNov 8, 2010 9:07 am 
Martin MakundiNov 8, 2010 9:13 am 
Omid MilaniNov 8, 2010 9:31 am 
Igor VaynbergNov 8, 2010 9:32 am 
Rodolfo HansenNov 8, 2010 10:01 am 
Eelco HilleniusNov 8, 2010 10:22 pm 
Martin MakundiNov 8, 2010 10:39 pm 
Martin MakundiNov 8, 2010 10:40 pm 
Carl-Eric MenzelNov 9, 2010 12:15 am 
Martin MakundiNov 9, 2010 12:19 am 
Martin MakundiNov 9, 2010 12:23 am 
Carl-Eric MenzelNov 9, 2010 12:41 am 
Carl-Eric MenzelNov 9, 2010 12:44 am 
Martin MakundiNov 9, 2010 1:01 am 
Carl-Eric MenzelNov 9, 2010 4:12 am 
Martin MakundiNov 9, 2010 4:21 am 
Vitaly TsaplinNov 9, 2010 4:29 am 
Martin MakundiNov 9, 2010 4:34 am 
Matthias KellerNov 9, 2010 4:46 am 
manuelbarziNov 9, 2010 4:49 am 
James CarmanNov 9, 2010 4:49 am 
Martin MakundiNov 9, 2010 4:54 am 
James CarmanNov 9, 2010 4:57 am 
Martin MakundiNov 9, 2010 4:58 am 
manuelbarziNov 9, 2010 5:26 am 
Martin MakundiNov 9, 2010 5:48 am 
Frank SilbermannNov 9, 2010 6:46 am 
Martin GrigorovNov 9, 2010 6:58 am 
Carl-Eric MenzelNov 9, 2010 7:02 am 
James CarmanNov 9, 2010 7:05 am 
Carl-Eric MenzelNov 9, 2010 7:11 am 
Carl-Eric MenzelNov 9, 2010 7:14 am 
Frank SilbermannNov 9, 2010 7:19 am 
Martin MakundiNov 9, 2010 7:20 am 
Martin MakundiNov 9, 2010 7:22 am 
James CarmanNov 9, 2010 7:26 am 
Frank SilbermannNov 9, 2010 7:28 am 
Martin MakundiNov 9, 2010 7:32 am 
Wilhelmsen Tor IverNov 9, 2010 7:32 am 
Martin MakundiNov 9, 2010 7:33 am 
Carl-Eric MenzelNov 9, 2010 7:36 am 
John OwenNov 9, 2010 7:36 am 
James CarmanNov 9, 2010 7:38 am 
Martin MakundiNov 9, 2010 7:45 am 
Frank SilbermannNov 9, 2010 7:48 am 
James CarmanNov 9, 2010 7:51 am 
Martin MakundiNov 9, 2010 7:57 am 
James CarmanNov 9, 2010 8:00 am 
Martin MakundiNov 9, 2010 8:04 am 
Carl-Eric MenzelNov 9, 2010 8:05 am 
Martin MakundiNov 9, 2010 8:06 am 
Martin MakundiNov 9, 2010 8:07 am 
Carl-Eric MenzelNov 9, 2010 8:10 am 
100 later messages
Subject:Re: Free wicket from component hierarchy hell
From:Omid Milani (omil@gmail.com)
Date:Nov 8, 2010 9:31:26 am
List:org.apache.wicket.users

Hi,

I think this approach of changing .add or adding a .queue is too radical while the purpose can be achieved in a much simpler way. I think hierarchy of Java code among other things helps considerably with code-readability and should be kept in pace, but also it's strictness sometimes makes one have to change the code for trivial markup change/requirement which is inconvenient.

So I suggest instead of tampering with code hierarchy, let markup override it with some special format in wicket:id - for example both these markups can work with the same java code: <a wicket:id="edit"><span wicket:id="name"/></a> <b wicket:id=":edit:name"/> (<a wicket:id="edit">edit</a>) (wicket:id=":edit:name" means relative path "edit:name" from the panel that owns the markup)

We just check for colon at markup id, resolve the component by relative path, determine it's visibility & enabled-ness the traditional way and render it. For ajax, I guess when rendering components we can check if it has children that have been rendered outside itself, if the child has outputMarkupId enabled just render that too, if not print a warn message that the markup designer has made a mistake there.

What do you think? Does this do what you want? Is there something I overlooked?

Omid

On Mon, Nov 8, 2010 at 8:28 PM, Igor Vaynberg <igor@gmail.com> wrote:

On Mon, Nov 8, 2010 at 8:51 AM, Sebastian <nosp@gmx.net> wrote:

Vigor,

as I understand the readme the queue method basically has only a slightly different behavior compared to the add method in the way that it either adds a component as a direct child to the parent or as a sub-child as defined in the markup. So the markup is only used to determine the child's location below a given (code controlled) parent. This means if you replace the current add method with the behavior of the queue method, existing code will still work and we would not have two separate ways to add components. That sounds like a good solution.

hrm. i was thinking to have queue() in addition to add(). i havent looked into it enough to be able to say that we can replace add() with queue() completely and not lose anything. if, however, that is the case, then i would prefer tweaking add() itself to work like queue().

-igor

@Martin: please start arguing with the given arguments and stop moaning. Thanks.

Regards, Seb

On 08.11.2010 17:28, Igor Vaynberg wrote:

it is not about fixing something that isnt broken, its about making it easier. anyways, i just updated the readme in my experimental branch that explains the solution a bit more: https://github.com/ivaynberg/wicket/tree/component-queuing

-igor

On Mon, Nov 8, 2010 at 8:23 AM, Vitaly Tsaplin<vita@gmail.com>  wrote:

I'm sorry to say, but the whole discussion makes little sense to me and these attempts to fix something that is not broken actually scares me a bit.

+1