atom feed6 messages in org.kde.rekonqRe: [rekonq] Review Request: Don't cr...
FromSent OnAttachments
Felix RohrbachSep 21, 2011 7:37 am 
Felix RohrbachSep 21, 2011 7:47 am 
Johannes TröscherSep 21, 2011 7:47 am 
Felix RohrbachSep 21, 2011 7:57 am 
Andrea DiamantiniSep 21, 2011 8:08 am 
Commit HookSep 21, 2011 8:54 am 
Subject:Re: [rekonq] Review Request: Don't crash if the rekonqui.rc file can't be found
From:Andrea Diamantini (adj@gmail.com)
Date:Sep 21, 2011 8:08:29 am
List:org.kde.rekonq

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102673/#review6711

-----------------------------------------------------------

Ship it!

Sounds good and safe :)

- Andrea

On Sept. 21, 2011, 2:57 p.m., Felix Rohrbach wrote:

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102673/

-----------------------------------------------------------

(Updated Sept. 21, 2011, 2:57 p.m.)

Review request for rekonq.

Summary

-------

Before, if a user ran rekonq locally without ever installing it, the missing
rekonqui.rc file resulted in a crash, without informing the user about the
problem. With this patch, the user gets a wrong interface and a debug line about
the missing file.

This addresses bug 282474. /show_bug.cgi?id=282474

Diffs

-----

src/mainwindow.cpp 12ecf7a

Diff: http://git.reviewboard.kde.org/r/102673/diff

Testing

Thanks,