atom feed13 messages in org.wso2.carbon-devRe: [Carbon-dev] [Code Review] Schedu...
FromSent OnAttachments
Afkham AzeezAug 29, 2011 8:32 pm 
Samisa AbeysingheAug 29, 2011 8:46 pm 
Thilina BuddhikaAug 30, 2011 7:53 am 
Tharindu MathewAug 30, 2011 9:28 am 
Nuwan BandaraAug 30, 2011 6:45 pm 
Janaka RanabahuAug 30, 2011 7:40 pm 
Amila Maha ArachchiAug 30, 2011 9:20 pm 
Afkham AzeezAug 30, 2011 9:41 pm 
Amila Maha ArachchiAug 30, 2011 9:58 pm 
Afkham AzeezAug 30, 2011 10:23 pm 
Amila Maha ArachchiAug 30, 2011 10:28 pm 
Afkham AzeezAug 30, 2011 10:39 pm 
Amila Maha ArachchiAug 30, 2011 10:50 pm 
Subject:Re: [Carbon-dev] [Code Review] Scheduled reviews for next week (5/9-9/9)
From:Afkham Azeez (aze@wso2.com)
Date:Aug 30, 2011 10:39:56 pm
List:org.wso2.carbon-dev

Were the review recommendations implemented ?

---- Sent from my phone On Aug 31, 2011 10:59 AM, "Amila Maha Arachchi" <ami@wso2.com> wrote:

On Wed, Aug 31, 2011 at 10:53 AM, Afkham Azeez <aze@wso2.com> wrote:

Where are the crucible notes? Better have an architecture review as well.

+1

Crucible link https://wso2.org/crucible/cru/COMPONENT-54

---- Sent from my phone On Aug 31, 2011 10:28 AM, "Amila Maha Arachchi" <ami@wso2.com> wrote:

On Wed, Aug 31, 2011 at 10:11 AM, Afkham Azeez <aze@wso2.com> wrote:

On Wed, Aug 31, 2011 at 9:51 AM, Amila Maha Arachchi <ami@wso2.com wrote:

On Tue, Aug 30, 2011 at 9:02 AM, Afkham Azeez <aze@wso2.com> wrote:

Please organize the following reviews.

Group A BAM Event Receiver - Tharindu

Group B Gadget Repository - Nuwan

Group C Authenticator Framework - Thilina

Group D Registry Indexing - Janaka

Group E Metering - AmilaM

Billing code needs lot of improvements. I am on support until next Tuesday. I'll try my best to do the improvements after that and present. If not I would like to request for one more week to do the refactoring.

How come the billing code that has been in development since last December suddenly need a "lot" of improvement? How did you suddenly come to realize this? What are these improvements? I'd suggest that you just present the code as it is for the review. If you remember, this review was

scheduled

1-2

weeks before the StratosLive launch and got delayed because of the release. I believe there was ample time to rectify the code.

Not suddenly. It was in the card for sometime. Although I started

working

on

it since February, my initial target was to get it working. I had to know the code.

This review was done on the scheduled date. You missed it because you were sick IIRC.

My concern is, the code needs design level changes. But I couldn't do them yet. Anyway, I'll present it as it is.

AmilaM.

-- *Afkham Azeez* Director of Architecture; WSO2, Inc.; http://wso2.com Member; Apache Software Foundation; http://www.apache.org/ * <http://www.apache.org/>** email: **aze@wso2.com* <aze@wso2.com>* cell: +94 77 3320919 blog: **http://blog.afkham.org* <http://blog.afkham.org>* twitter: **http://twitter.com/afkham_azeez*<

http://twitter.com/afkham_azeez>

* linked-in: **http://lk.linkedin.com/in/afkhamazeez* * * *Lean . Enterprise . Middleware*

-- *Afkham Azeez* Director of Architecture; WSO2, Inc.; http://wso2.com Member; Apache Software Foundation; http://www.apache.org/ * <http://www.apache.org/>** email: **aze@wso2.com* <aze@wso2.com>* cell: +94 77 3320919 blog: **http://blog.afkham.org* <http://blog.afkham.org>* twitter: **http://twitter.com/afkham_azeez*<

http://twitter.com/afkham_azeez>

* linked-in: **http://lk.linkedin.com/in/afkhamazeez* * * *Lean . Enterprise . Middleware*