16 messages in org.freebsd.freebsd-archRe: pipe/fifo code merged.| From | Sent On | Attachments |
|---|---|---|
| Giovanni Trematerra | Jan 7, 2012 6:35 pm | |
| John Baldwin | Jan 9, 2012 5:48 am | |
| Bruce Evans | Jan 9, 2012 6:34 am | |
| Kostik Belousov | Jan 9, 2012 6:46 am | |
| Giovanni Trematerra | Jan 9, 2012 2:27 pm | |
| Giovanni Trematerra | Jan 9, 2012 3:19 pm | |
| Bruce Evans | Jan 10, 2012 4:03 am | |
| Giovanni Trematerra | Jan 10, 2012 3:04 pm | |
| Giovanni Trematerra | Jan 10, 2012 3:33 pm | |
| Giovanni Trematerra | Jan 10, 2012 4:14 pm | |
| Giovanni Trematerra | Jan 12, 2012 12:55 am | |
| Bruce Evans | Jan 12, 2012 4:51 am | |
| Giovanni Trematerra | Jan 17, 2012 3:42 am | |
| Jilles Tjoelker | Jan 28, 2012 3:36 pm | |
| Bruce Evans | Jan 29, 2012 3:31 am | |
| Giovanni Trematerra | Jan 31, 2012 1:48 pm |
| Subject: | Re: pipe/fifo code merged. | |
|---|---|---|
| From: | Jilles Tjoelker (jil...@stack.nl) | |
| Date: | Jan 28, 2012 3:36:49 pm | |
| List: | org.freebsd.freebsd-arch | |
On Tue, Jan 17, 2012 at 12:43:19PM +0100, Giovanni Trematerra wrote:
Did you agree that this patch http://www.trematerra.net/patches/pipefifo_merge2.4.diff
doesn't introduce any further regressions while it fixes
- style bugs you pointed out. - pipe_stat now use underlying filesystem information for pipes. - comment about pipeinfo was intended for. - race into pipe_poll (look at fifo_iseof line).
I tested this version of the patch and found that it breaks opening a fifo with O_TRUNC: it fails with [EINVAL]. This appears to be pipe_truncate()'s doing. Previously, truncate requests went to the vnode.
In particular, this happens when opening a fifo for writing using sh(1)'s > (unless 'set -C' is in effect) or >| redirection operators. The open properly blocks until a reader arrives but then fails with [EINVAL]. Several tests in tools/regression/bin/sh do this.
-- Jilles Tjoelker
_______________________________________________ free...@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-arch To unsubscribe, send any mail to "free...@freebsd.org"