40 messages in org.freebsd.freebsd-archRe: CFR: m_tag patch| From | Sent On | Attachments |
|---|---|---|
| Sam Leffler | Oct 6, 2002 9:38 pm | |
| Nate Lawson | Oct 6, 2002 10:01 pm | |
| Sam Leffler | Oct 6, 2002 10:21 pm | |
| Terry Lambert | Oct 6, 2002 11:09 pm | |
| Julian Elischer | Oct 6, 2002 11:32 pm | |
| Julian Elischer | Oct 7, 2002 12:29 am | |
| Sam Leffler | Oct 7, 2002 9:24 am | |
| Sam Leffler | Oct 7, 2002 9:31 am | |
| Sam Leffler | Oct 7, 2002 9:46 am | |
| Julian Elischer | Oct 7, 2002 2:20 pm | |
| Terry Lambert | Oct 7, 2002 3:34 pm | |
| Sam Leffler | Oct 7, 2002 3:52 pm | |
| Julian Elischer | Oct 7, 2002 4:10 pm | |
| Julian Elischer | Oct 7, 2002 4:22 pm | |
| Luigi Rizzo | Oct 7, 2002 4:30 pm | |
| Julian Elischer | Oct 7, 2002 4:55 pm | |
| Sam Leffler | Oct 7, 2002 5:06 pm | |
| Julian Elischer | Oct 7, 2002 5:10 pm | |
| Julian Elischer | Oct 7, 2002 5:14 pm | |
| Julian Elischer | Oct 7, 2002 5:23 pm | |
| Terry Lambert | Oct 7, 2002 5:31 pm | |
| Terry Lambert | Oct 7, 2002 5:47 pm | |
| Nate Lawson | Oct 7, 2002 10:42 pm | |
| Don Lewis | Oct 7, 2002 11:06 pm | |
| Julian Elischer | Oct 7, 2002 11:28 pm | |
| Julian Elischer | Oct 7, 2002 11:32 pm | |
| Terry Lambert | Oct 8, 2002 12:42 am | |
| Terry Lambert | Oct 8, 2002 12:53 am | |
| Harti Brandt | Oct 8, 2002 1:19 am | |
| Nate Lawson | Oct 8, 2002 11:25 am | |
| Don Lewis | Oct 8, 2002 12:15 pm | |
| Sam Leffler | Oct 8, 2002 6:25 pm | |
| JINMEI Tatuya / 神明達哉 | Oct 10, 2002 7:33 pm | |
| Sam Leffler | Oct 11, 2002 11:11 am | |
| JINMEI Tatuya / 神明達哉 | Oct 16, 2002 3:03 am | |
| Luigi Rizzo | Oct 16, 2002 7:45 am | |
| JINMEI Tatuya / 神明達哉 | Oct 16, 2002 11:06 am | |
| Luigi Rizzo | Oct 16, 2002 11:18 am | |
| Julian Elischer | Oct 16, 2002 11:24 am | |
| Sam Leffler | Oct 16, 2002 11:29 am |
| Subject: | Re: CFR: m_tag patch | |
|---|---|---|
| From: | Sam Leffler (sa...@errno.com) | |
| Date: | Oct 16, 2002 11:29:03 am | |
| List: | org.freebsd.freebsd-arch | |
On Thu, Oct 17, 2002 at 03:07:07AM +0900, JINMEI Tatuya / ?$B?@L@C#:H?(B wrote: ...
(I re-read the thread) perhaps the example in my previous message wasn't good (and it was at least incorrect). According to the discussion on the thread, we'll probably keep m_tag_cookie being 0 and use m_tag_id in (e.g.) ip6_output.c. So, we'll be happy if this convention is kept (and will be kept) at least under netinet6.
unfortunately this will not prevent code from having to check that the m_tag_cookie actually corresponds to the value you want, to make sure that your code does not misinterpret as own tags generated/destined to other clients.
Am I correct, Sam ?
Correct. If you explicitly look inside the m_tag structure instead of using one of the m_tag_* routines to search then you will need to validate m_tag_cookie to avoid interpreting tags created by other modules. The comments I wrote in mbuf.h for this stuff describe this and say that when writing code that is to be compatible with other systems one should always use MTAG_ABI_COMPAT and the openbsd-compatible m_tag_get and m_tag_find routines.
m_tag_cookie was mainly added so that netgraph could piggyback on top of the facility and remove it's private code. At some point it may be worthwhile to talk with the openbsd+netbsd folks about adopting this new m_tag facility.
Sam
To Unsubscribe: send mail to majo...@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message