69 messages in com.selenic.mercurial-develRe: [PATCH 1 of 4] commit: prevent to...| From | Sent On | Attachments |
|---|---|---|
| Martin Geisler | May 7, 2010 10:33 am | |
| Dirkjan Ochtman | May 7, 2010 10:37 am | |
| Matt Mackall | May 7, 2010 10:59 am | |
| Martin Geisler | May 7, 2010 11:14 am | |
| Matt Mackall | May 7, 2010 11:46 am | |
| Dirkjan Ochtman | May 7, 2010 1:14 pm | |
| Gilles Moris | May 8, 2010 12:10 am | |
| Martin Geisler | May 8, 2010 1:31 am | |
| Martin Geisler | May 8, 2010 1:34 am | |
| Martin Geisler | May 8, 2010 1:48 am | |
| Martin Geisler | May 8, 2010 2:09 am | |
| Gilles Moris | May 8, 2010 3:50 am | |
| Martin Geisler | May 8, 2010 1:10 pm | |
| Gilles Moris | May 9, 2010 9:33 am | |
| Gilles Moris | May 9, 2010 1:49 pm | |
| Gilles Moris | May 9, 2010 1:49 pm | |
| Gilles Moris | May 9, 2010 1:49 pm | |
| Gilles Moris | May 9, 2010 1:49 pm | |
| Gilles Moris | May 9, 2010 1:49 pm | |
| Matt Mackall | May 9, 2010 2:36 pm | |
| Matt Mackall | May 9, 2010 2:43 pm | |
| Matt Mackall | May 9, 2010 2:45 pm | |
| Matt Mackall | May 9, 2010 2:47 pm | |
| Martin Geisler | May 9, 2010 4:11 pm | |
| Dirkjan Ochtman | May 9, 2010 10:50 pm | |
| Gilles Moris | May 9, 2010 11:31 pm | |
| Gilles Moris | May 9, 2010 11:49 pm | |
| Matt Mackall | May 10, 2010 12:04 am | |
| Gilles Moris | May 10, 2010 12:37 am | |
| Gilles Moris | May 10, 2010 12:37 am | |
| Matt Mackall | May 10, 2010 12:38 am | |
| Matt Mackall | May 10, 2010 12:58 am | |
| Sune Foldager | May 11, 2010 2:02 am | |
| Sune Foldager | May 11, 2010 2:08 am | |
| Sune Foldager | May 11, 2010 2:14 am | |
| Sune Foldager | May 11, 2010 2:20 am | |
| Matt Mackall | May 11, 2010 3:53 pm | |
| Matt Mackall | May 11, 2010 3:56 pm | |
| Gilles Moris | May 12, 2010 12:52 am | |
| Gilles Moris | May 12, 2010 1:15 am | |
| Gilles Moris | May 12, 2010 1:15 am | |
| Gilles Moris | May 12, 2010 1:15 am | |
| Gilles Moris | May 12, 2010 1:15 am | |
| Gilles Moris | May 12, 2010 1:15 am | |
| Gilles Moris | May 12, 2010 5:17 am | |
| Augie Fackler | May 12, 2010 7:35 am | |
| Matt Mackall | May 12, 2010 8:33 am | |
| Matt Mackall | May 12, 2010 8:34 am | |
| Matt Mackall | May 12, 2010 8:34 am | |
| Matt Mackall | May 12, 2010 8:55 am | |
| Gilles Moris | May 12, 2010 2:33 pm | |
| Gilles Moris | May 13, 2010 7:31 am | |
| Matt Mackall | May 13, 2010 1:48 pm | |
| Martin Geisler | May 17, 2010 1:09 am | |
| Martin Geisler | May 17, 2010 1:22 am | |
| Rafael Villar Burke (Pachi) | May 17, 2010 2:07 am | |
| Augie Fackler | May 17, 2010 5:57 am | |
| Martin Geisler | May 17, 2010 6:56 am | |
| Augie Fackler | May 17, 2010 7:46 am | |
| Martin Geisler | May 17, 2010 8:13 am | |
| Augie Fackler | May 17, 2010 8:41 am | |
| Gilles Moris | May 19, 2010 8:00 am | |
| Martin Geisler | May 19, 2010 3:53 pm | |
| Martin Geisler | May 19, 2010 3:58 pm | |
| Augie Fackler | May 24, 2010 5:15 am | |
| Peter Arrenbrecht | May 26, 2010 6:23 am | |
| Rafael Fernández López | Jun 3, 2010 5:35 am | |
| Peter Arrenbrecht | Jun 3, 2010 6:14 am | |
| Martin Geisler | Jun 4, 2010 12:18 am |
| Subject: | Re: [PATCH 1 of 4] commit: prevent to close non head changesets | |
|---|---|---|
| From: | Matt Mackall (mp...@selenic.com) | |
| Date: | May 9, 2010 2:43:52 pm | |
| List: | com.selenic.mercurial-devel | |
On Sun, 2010-05-09 at 22:50 +0200, Gilles Moris wrote:
mercurial/commands.py | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
# HG changeset patch # User Gilles Moris <gill...@free.fr> # Date 1273437438 -7200 # Node ID 9ab8b7dc5065557877d765b4f524ceb9cb1751e3 # Parent 0b465972baec1efccb4bf1a92992519665332713 commit: prevent to close non head changesets
diff -r 0b465972baec -r 9ab8b7dc5065 mercurial/commands.py --- a/mercurial/commands.py Tue May 04 09:57:16 2010 +0200 +++ b/mercurial/commands.py Sun May 09 22:37:18 2010 +0200 @@ -717,6 +717,8 @@ """ extra = {} if opts.get('close_branch'): + if repo['.'].node() not in repo.branchheads(): + raise util.Abort(_('cannot close non head changeset'))
Seems sensible. Should be 'non-head', though I think we should say something like 'can only close branch heads' instead.
-- Mathematics is the supreme nostalgia of our time.
_______________________________________________ Mercurial-devel mailing list Merc...@selenic.com http://selenic.com/mailman/listinfo/mercurial-devel