On Fri, Nov 23, 2001 at 04:11:36PM +0300, Sergey A. Osokin wrote:
@@ -71,7 +71,7 @@
static void badformat __P((void));
static void usage __P((void));
-int logwtmp __P((char *, char *, char *));
+int logwtmp __P((const char *, const char *, const char *));
The manual page for logwtmp() clearly states that <libutil.h> needs to
be included, the correct prototype is there. Remove the bogus prototype
from date.c and include libutil.h instead.
int
main(argc, argv)
@@ -148,7 +148,7 @@
if (!rflag && time(&tval) == -1)
err(1, "time");
- format = "%+";
+ format = strdup("%+");
This change is incorrect. Strdup allocates memory which you never free.
The correct solution to the warning created by this line is to change
the type of 'format' from "char *" to "const char *".
diff -ruN date.orig/vary.c date/vary.c
--- date.orig/vary.c Fri Nov 23 10:57:45 2001
+++ date/vary.c Fri Nov 23 13:08:31 2001
@@ -430,7 +430,7 @@
if (type == '\0')
t->tm_isdst = -1;
- if (strspn(arg, digits) != len-1) {
+ if ((int)strspn(arg, digits) != len-1) {
val = trans(trans_wday, arg);
if (val != -1) {
if (!adjwday(t, type, val, 1, 1))
A more appropriate fix is to change the type of 'len' from int to
size_t, 'len' is initially assigned the return of strlen() which is also
a size_t.
To Unsubscribe: send mail to majo...@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
10 messages in org.freebsd.freebsd-auditRe: date(1) WARNS=2 cleanup
.Other