atom feed13 messages in net.java.dev.glassfish.adminRe: New CLI
FromSent OnAttachments
Byron NevinsJun 29, 2009 10:59 am 
Lloyd ChambersJun 29, 2009 4:56 pm 
Bill ShannonJun 29, 2009 5:08 pm 
Sreenivas MunnangiJun 29, 2009 7:21 pm 
Bill ShannonJun 30, 2009 12:13 pm 
Paul DaviesJun 30, 2009 1:30 pm 
Bill ShannonJun 30, 2009 3:28 pm 
Paul DaviesJun 30, 2009 4:13 pm 
Kedar MhaswadeJul 1, 2009 6:59 am 
Tim QuinnJul 2, 2009 2:50 pm 
Byron NevinsJul 2, 2009 3:40 pm 
Tim QuinnJul 2, 2009 3:46 pm 
Bill ShannonJul 2, 2009 7:06 pm 
Subject:Re: New CLI
From:Bill Shannon (bill@sun.com)
Date:Jul 2, 2009 7:06:57 pm
List:net.java.dev.glassfish.admin

Yes, it's a bug. This special case support for --upload was broken when I removed support for --path. I thought quicklook tested this too, but apparently not. Guess I should add that.

This would all be a bit cleaner if the server side commands defined an upload parameter, even if the special handling for it is on the client.

Tim Quinn wrote on 7/2/09 3:47 PM:

Byron Nevins wrote:

Are you sure? QL passes. Doesn't QL use the --upload arg?

$ echo $ASADMIN_NEW true $ asadmin deploy --upload=true /Users/Tim/asgroup/v3/v2/appserv-tests/devtests/deployment/build/WebNBean.ear

com.sun.enterprise.cli.framework.CommandException: remote failure: I*nvalid option: upload* Usage: deploy [ --virtualservers virtual_servers] [--contextroot context_root] [--force=false] [ --precompilejsp=false] [ --name component_name] [--upload=true] [ --retrieve local_dirpath] [--dbvendorname dbvendorname] [--createtables=true | --dropandcreatetables=true] [ --uniquetablenames=true] [ --deploymentplan deployment_plan] [--enabled=true] [ --libraries jar_file[,jar_file*]] [--type pkg-type] [--properties(name=value)[:name=value]*] file_archive| filepath

Command deploy failed.

Bill Shannon wrote:

Byron Nevins wrote on 06/29/09 11:00:

To start using the new CLI just set this environmental variable semi-permanently

ASADMIN_NEW=true

It looks as if file uploading is broken during deployment.

The definition of the DeployCommandParameters (extended by DeployCommand and ReDeployCommand) does not include --upload. (That used to be detected by the old admin CLI client which took some other actions.) So the CLI rejects --upload on the deploy command now.

What's the fix in the new scheme?