atom feed4 messages in org.kde.rekonqRe: [rekonq] Review Request: Fixes th...
FromSent OnAttachments
Vedant AgarwalaDec 10, 2012 10:21 pm 
Tirtha ChatterjeeDec 10, 2012 10:24 pm 
Andrea DiamantiniDec 11, 2012 8:59 am 
Commit HookDec 12, 2012 9:50 am 
Subject:Re: [rekonq] Review Request: Fixes the modifier+enter completion (like addition of .com, .org, .net)
From:Tirtha Chatterjee (tirt@gmail.com)
Date:Dec 10, 2012 10:24:30 pm
List:org.kde.rekonq

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107662/#review23298

-----------------------------------------------------------

Ship it!

Looks good to me!

On Dec. 11, 2012, 6:21 a.m., Vedant Agarwala wrote:

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107662/

-----------------------------------------------------------

(Updated Dec. 11, 2012, 6:21 a.m.)

Review request for rekonq.

Description

-------

There was a bug due to which, when we typed a url like "goal" and pressed
ctrl+enter, the .com was not appended. Actually, two urls were being opened in
quick succession, one with the .com appended, another one without it (taken from
the completion list's url).

This patch fixes it, by not progressing to load the list's url, and stopping
after emitting the appended url.

Diffs

-----

src/urlbar/completionwidget.cpp 04f7bad

Diff: http://git.reviewboard.kde.org/r/107662/diff/

Testing

-------

Tested manually. Works.

Thanks,

Vedant Agarwala