6 messages in org.freebsd.freebsd-portsRe: SUBDIR in Makefiles - usage thereof| From | Sent On | Attachments |
|---|---|---|
| Julian Howard Stacey | May 17, 1995 5:33 am | |
| Satoshi Asami | 浅見 賢 | May 17, 1995 10:04 am | |
| Rodney W. Grimes | May 17, 1995 1:04 pm | |
| Jean-Marc Zucconi | May 17, 1995 1:50 pm | |
| Satoshi Asami | 浅見 賢 | May 18, 1995 1:06 am | |
| Julian Howard Stacey | May 18, 1995 4:54 am |
| Subject: | Re: SUBDIR in Makefiles - usage thereof | |
|---|---|---|
| From: | Rodney W. Grimes (rgri...@gndrsh.aac.dev.com) | |
| Date: | May 17, 1995 1:04:46 pm | |
| List: | org.freebsd.freebsd-ports | |
* SUBDIR?= * SUBDIR += this * SUBDIR += that * SUBDIR += the_other * SUBDIR += foobar
Actually I thought about this before when I was cleaning up the Makefiles, the reason why I didn't want to go for it at that time was because I thought it will make the subdir Makefiles too long and scroll off my screen.
This is a good idea!
...
Also, it will make it easier when we formally support the RESTRICTED and BROKEN keywords, as we can do something like
BROKEN += a_broken_port SUBDIR += a_good_port RESTRICTED += cryptic_port SUBDIR += great_port SUBDIR += some_port RESTRICTED += what_a_jerk
Another Good Idea(TM), infact his one is a Better Idea!!
and still have them in alphabetical order. :)
* This minor change buys flexibility, it's also been tried & tested before * (& is still to be seen in such files as src/Makefile)
BTW, I definitely don't want turn this into a sea of
.if exists(foodir) SUBDIR += foodir .endif
Please don't I am about to rewrite that into something like this:
SUBDIR= .for i in ${DIRLIST} .if exits(${i}) SUBDIR+= ${i} .endif .endfor
the next 24 hours or so, I'll go ahead and update all the Makefiles.
I object, you are in code freeze, don't go do a wide sweeping change like this, wait for after 2.0.5.
-- Rod Grimes rgri...@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD