12 messages in com.mysql.lists.plusplusRe: [PATCH] Re: equal_list() using a ...
FromSent OnAttachments
Mark Merendino03 May 2005 14:16 
Chris Frey03 May 2005 15:20 
Warren Young03 May 2005 16:28 
Mark Merendino05 May 2005 09:37 
Warren Young10 May 2005 10:10 
Chris Frey10 May 2005 13:12 
Warren Young10 May 2005 13:35 
Chris Frey10 May 2005 14:05 
Mark Merendino11 May 2005 05:51 
Warren Young11 May 2005 11:52 
Chris Frey11 May 2005 13:33 
Warren Young11 May 2005 14:08 
Subject:Re: [PATCH] Re: equal_list() using a bool vector
From:Warren Young (mysq@etr-usa.com)
Date:05/10/2005 01:35:20 PM
List:com.mysql.lists.plusplus

Chris Frey wrote:

... there is a template member function that has no definition in the rest of the header. Specifically:

Thank you for the explanation.

Below is Mark's patch, diff-ified,

Thanks again.

plus some warning fixes for out-of-order constructor arguments

This is good to fix, but you should to do it by reordering the initializer list, not by reordering the member declarations. I don't think it's an ABI breakage to make the change as you have, but it is needless.

Index: software/mysql++/examples/custom1.cpp

I'd rather that you created a new example, rather than modify custom1.cpp. Disk space is cheap; adding custom5.cpp won't be a problem.

+ a[stock_weight] = true; + a[stock_price] = true;

I retract my wish for bare constants here. I didn't realize that custom.h defined these constants for you. It will be good to document this in an example.

Last but not least, can we get a DocBook comment for the new functions? I'm going to request this increasingly, so you all might as well get used to it. :) I'm not going to have all that hard work in the new docs go to waste by letting them slip back into irrelevancy.