|Charles Randall||Nov 17, 1999 10:47 am|
|Matthew Dillon||Nov 17, 1999 10:51 am|
|Charles Randall||Nov 18, 1999 12:18 am|
|Matthew Dillon||Nov 18, 1999 12:28 am|
|Alfred Perlstein||Nov 18, 1999 2:41 am|
|Matthew Dillon||Nov 18, 1999 8:43 am|
|Peter Wemm||Nov 18, 1999 8:21 pm|
|Matthew Dillon||Nov 18, 1999 8:43 pm|
|Peter Wemm||Nov 18, 1999 9:31 pm|
|Matthew Dillon||Nov 19, 1999 8:51 am|
|Bruce Evans||Nov 19, 1999 10:45 am|
|Luoqi Chen||Nov 19, 1999 10:51 am|
|Alan Cox||Nov 19, 1999 11:04 am|
|Julian Elischer||Nov 19, 1999 11:07 am|
|Matthew Dillon||Nov 19, 1999 11:32 am|
|Matthew Dillon||Nov 19, 1999 11:33 am|
|Alfred Perlstein||Nov 19, 1999 11:42 am|
|Subject:||Re: Big Giant Lock progress?|
|From:||Matthew Dillon (dil...@apollo.backplane.com)|
|Date:||Nov 18, 1999 8:43:07 pm|
: :I have a problem with this portion of the smp-patch-02.diff: : :Index: sys/lock.h :=================================================================== :RCS file: /home/ncvs/src/sys/sys/lock.h,v :retrieving revision 1.16 :diff -u -r1.16 lock.h :--- lock.h 1999/08/28 00:51:50 1.16 :+++ lock.h 1999/11/18 08:22:37 :@@ -208,4 +208,15 @@ : #endif /* NCPUS == 1 */ : #endif /* !SIMPLELOCK_DEBUG */ : :+#ifdef SMP :+void get_mplock(void); :+void rel_mplock(void); :...
Yes, that's actually not part of my patch set, but Alfred's, thanks for pointing it out! I accidently left it in there. It will not be part of the commit.
That said, I'm not sure it's possible to make modules SMP-unaware unless we commit ourselves to having dummy mplock and simplelock procedures for non-SMP kernels. i.e. real procedures that are empty instead of a #define to non-existance.
Without a kernel device driver or module API, we are pretty much S.O.L. with modules already - if you don't recompile your modules when you recompile the kernel, bad things often happen.
-Matt Matthew Dillon <dil...@backplane.com>
:+#define GET_SYSCALL_LOCK get_mplock() :+#define REL_SYSCALL_LOCK rel_mplock() :+#else /* !SMP */ :+#define GET_SYSCALL_LOCK :+#define REL_SYSCALL_LOCK :+#endif /* SMP */ :+ :+ : #endif /* !_LOCK_H_ */ : :This appears to be unrelated to the MPgetlock etc code so it may not be :intended to be there. However, the problem is that it looks like it's :exposing more "#ifdef SMP" to modules.. This is a problem if we have to :have a SMP vs non-SMP set of modules for 4.0-RELEASE, especially for things :like OSS. Obviously I haven't seen the code, but please keep this in mind. : :Cheers, :-Peter
To Unsubscribe: send mail to majo...@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message