43 messages in org.apache.mina.devRe: svn commit: r659372 - /mina/branc...
FromSent OnAttachments
Emmanuel LecharnyMay 22, 2008 7:40 pm 
이희승 (Trustin Lee)May 22, 2008 7:46 pm 
Emmanuel LecharnyMay 22, 2008 8:02 pm 
이희승 (Trustin Lee)May 22, 2008 8:14 pm 
Emmanuel LecharnyMay 22, 2008 8:21 pm 
Emmanuel LecharnyMay 22, 2008 8:24 pm 
이희승 (Trustin Lee)May 22, 2008 8:30 pm 
Emmanuel LecharnyMay 22, 2008 8:43 pm 
이희승 (Trustin Lee)May 22, 2008 8:48 pm 
Mike HeathMay 22, 2008 9:52 pm 
이희승 (Trustin Lee)May 22, 2008 9:59 pm 
이희승 (Trustin Lee)May 22, 2008 10:20 pm 
Emmanuel LecharnyMay 22, 2008 10:31 pm 
이희승 (Trustin Lee)May 22, 2008 10:35 pm 
Mike HeathMay 22, 2008 10:44 pm 
Rich DoughertyMay 22, 2008 11:24 pm 
Julien VermillardMay 22, 2008 11:37 pm 
이희승 (Trustin Lee)May 22, 2008 11:44 pm 
Julien VermillardMay 23, 2008 12:13 am 
이희승 (Trustin Lee)May 23, 2008 12:39 am 
Michael QiMay 23, 2008 12:46 am 
Stefano BagnaraMay 23, 2008 1:09 am 
Stefano BagnaraMay 23, 2008 1:17 am 
Julien VermillardMay 23, 2008 1:21 am 
Brad HarveyMay 23, 2008 1:45 am 
Mark WebbMay 23, 2008 6:09 am 
Brad HarveyMay 23, 2008 6:31 am 
Niklas TherningMay 23, 2008 6:54 am 
Alex KarasuluMay 23, 2008 7:30 am 
Emmanuel LecharnyMay 23, 2008 7:50 am 
Emmanuel LecharnyMay 23, 2008 8:07 am 
Julien VermillardMay 23, 2008 8:44 am 
Stefano BagnaraMay 23, 2008 10:03 am 
Alex KarasuluMay 23, 2008 10:14 am 
Mark WebbMay 23, 2008 10:16 am 
Stefano BagnaraMay 23, 2008 10:26 am 
Stefano BagnaraMay 23, 2008 10:28 am 
Emmanuel LecharnyMay 23, 2008 10:40 am 
Mark WebbMay 23, 2008 1:43 pm 
Emmanuel LecharnyMay 23, 2008 2:23 pm 
jver...@archean.frMay 24, 2008 11:07 pm 
Frédéric BrégierMay 24, 2008 11:26 pm 
Emmanuel LecharnyMay 25, 2008 4:00 am 
Actions with this message:
Paste this link in email or IM:
Paste this link in email or IM:
Atom feed for this thread
Paste this URL into your reader:
Subject:Re: svn commit: r659372 - /mina/branches/buffer/core/src/main/java/org/apache/mina/queue/DefaultByteBufferQueue.javaActions...
From:Mike Heath (mhe@apache.org)
Date:May 22, 2008 9:52:26 pm
List:org.apache.mina.dev

Emmanuel Lecharny wrote:

이희승 (Trustin Lee) wrote:

Every public methods except for the constructors are overridden from its supertypes and interfaces. They all got proper JavaDoc comments. Let me know if I am missing something.

Adding a @see Class#method() in the implementation then should help. When you look at a method javadoc it's better to know where too look at : the intheritance scheme can be feilry complex, and it can be a burden to retreive the associated Javadoc.

Something like : /** * @see javax.naming.Context#close() */ public void close() throws NamingException ...

I think @see is the wrong approach for this situation. We should use @inheritedDoc instead of @see. With @see you get no useful information if your IDE supports in-editor popup docs. You also have to make an extra click to get to useful information when browsing the JavaDocs which is almost as annoying as empty docs.

Also with @inheritedDoc you can see immediately in the code that there are JavaDocs for the method.

IMO using @inheritedDoc instead of empty JavaDocs should be the standard practice in any Java project.

-Mike