Re: [Xen-ia64-devel] [PATCH 4/5] kexec: fix /proc/iomem_machine - Simon Horman - com.xensource.lists.xen-ia64-devel

11 messages in com.xensource.lists.xen-ia64-develRe: [Xen-ia64-devel] [PATCH 4/5] kexe...

From	Sent On	Attachments
Isaku Yamahata	23 Jul 2008 22:59	.patch
Simon Horman	24 Jul 2008 01:03
Isaku Yamahata	24 Jul 2008 01:15
Simon Horman	24 Jul 2008 01:25
Simon Horman	24 Jul 2008 02:55
Isaku Yamahata	24 Jul 2008 21:45
Isaku Yamahata	24 Jul 2008 21:46
Isaku Yamahata	24 Jul 2008 21:47
Simon Horman	27 Jul 2008 20:47
Simon Horman	27 Jul 2008 20:47
Simon Horman	27 Jul 2008 20:48

Subject:	Re: [Xen-ia64-devel] [PATCH 4/5] kexec: fix /proc/iomem_machine
From:	Simon Horman (hor...@verge.net.au)
Date:	07/27/2008 08:47:40 PM
List:	com.xensource.lists.xen-ia64-devel

On Fri, Jul 25, 2008 at 01:46:03PM +0900, Isaku Yamahata wrote:

On Thu, Jul 24, 2008 at 07:55:48PM +1000, Simon Horman wrote:

I think that saved_max_pfn isn't entirely related to the problem that you are seeing. On Linux it is used in the second kernel after crash dump to deterimin the size of /proc/vmcore - that is to make it match the physical memory rather than the limited memory that the crash dump kernel runs in.

As a crash dump kernel currently can't be a dom0 (or domU) kernel, I don't think that it is that important in the context of linux-xen. We could probably even eliminate it, but it seems better to leave it rather than add diferences to upstram linux.

Also, while looking into your change I came across f4a570997e71b892805a1e71303d09c327af135f in upstream Linux. Again, it isn't needed in our code as our tree won't run as a crash dump kernel. But it might be good to align the code with what is in upstram Linux.

Lastly, your change is already present in upstram Linux, I'm not sure how I managed to miss adding it to xen-Linux. Sorry about that :-(

So I backported f4a570997e71b892805a1e71303d09c327af135f and e55fdf11f3029bcd41b1b9547ad9db12c27eea76.

And here is the updated patch.

[IA64] initialize /proc/iomem_machine properly when discontig mem.

With CONFIG_DISCONTIGMEM enabled /proc/iomem_machine isn't initialized properly so that kexec failes because kexec-tools wrongly tries to use ia64 boot mem (or efi memmap area). This patch fixes /proc/iomem_machine.