6 messages in com.xensource.lists.xen-develRe: [Xen-devel] [PATCH] Changes to al...
FromSent OnAttachments
Rob Gardner30 Oct 2005 13:14.Other
David Hopwood30 Oct 2005 14:52 
Rob Gardner30 Oct 2005 14:59 
David Hopwood30 Oct 2005 15:02 
Keir Fraser30 Oct 2005 23:53 
Rob Gardner31 Oct 2005 06:42 
Subject:Re: [Xen-devel] [PATCH] Changes to allow dynamic enabling/disabling of trace buffers
From:David Hopwood (davi@blueyonder.co.uk)
Date:10/30/2005 03:02:19 PM
List:com.xensource.lists.xen-devel

Rob Gardner wrote:

// 3. Changing size ==> deallocate and reallocate? Or disallow? // User can just do a change to 0, then a change to the new size.

They can, but the interface is slightly simpler if you allow this, and the implementation is also slightly shorter because you don't have to check for the error, or comment on it: [...] The sentence "To change the size of an existing allocation, you must first deallocate it then reallocate it." should also be removed from the xc_tbuf_set_size doc comment.

For the implementation I gave, replace it with "If the call fails (e.g. due to lack of memory), the size may be set to zero."